From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Lang Daniel via buildroot <buildroot@buildroot.org>
Cc: Lang Daniel <d.lang@abatec.at>,
"tuzakli.refik@gmail.com" <tuzakli.refik@gmail.com>,
Gary Bisson <bisson.gary@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/3] package/freescale-imx/imx-gpu-viv: drop X11 output
Date: Sat, 14 Jan 2023 23:00:28 +0100 [thread overview]
Message-ID: <20230114230028.46833cae@windsurf> (raw)
In-Reply-To: <VI1P190MB0493F15E5CA3D6BC8CCD52029FFF9@VI1P190MB0493.EURP190.PROD.OUTLOOK.COM>
On Tue, 10 Jan 2023 09:32:43 +0000
Lang Daniel via buildroot <buildroot@buildroot.org> wrote:
> Since e8df0f7 (package/freescale-imx/imx-gpu-viv: bump to version 6.4.3.p4.4)
> the X11 folder is no longer included in the archive.
>
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
I've applied with minor tweaks. See below.
> +config BR2_PACKAGE_IMX_GPU_VIV_OUTPUT_X11
> + bool "imx-gpu-viv X11 output has been removed"
select BR2_LEGACY
was missing here to make sure the build doesn't start if this option is
enabled.
> + help
> + The X11 output was dropped by NXP.
> +
> config BR2_PACKAGE_QEMU_CUSTOM_TARGETS
> string "the QEMU specific targets option has been removed"
> help
> diff --git a/package/freescale-imx/imx-gpu-viv/Config.in b/package/freescale-imx/imx-gpu-viv/Config.in
> index 9ba3d0428e..bc30798ca5 100644
> --- a/package/freescale-imx/imx-gpu-viv/Config.in
> +++ b/package/freescale-imx/imx-gpu-viv/Config.in
> @@ -27,8 +27,8 @@ config BR2_PACKAGE_IMX_GPU_VIV
> Userspace libraries for Vivante GPU on i.MX platforms
>
> It contains libraries and headers for GLES, OpenCL, and
> - OpenVG. It also contains a DRI plugin for X11. It also
> - contains a plugin for DirectFB-1.4.0, but that doesn't work
> + OpenVG. It also contains a plugin for DirectFB-1.4.0,
> + but that doesn't work
> together with buildroot's DirectFB version.
This paragraph should have been rewrapped after your change.
Other than that, looks good so I've applied. Of course, it might be
surprising for people who might be using X11 with OpenGL support on
i.MX platforms... but we're simply following the choice made by
upstream.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-01-14 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 9:32 [Buildroot] [PATCH 1/3] package/freescale-imx/imx-gpu-viv: drop X11 output Lang Daniel via buildroot
2023-01-14 22:00 ` Thomas Petazzoni via buildroot [this message]
2023-02-06 14:37 ` Peter Korsgaard
2023-02-06 14:56 ` Thomas Petazzoni via buildroot
2023-02-06 16:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114230028.46833cae@windsurf \
--to=buildroot@buildroot.org \
--cc=bisson.gary@gmail.com \
--cc=d.lang@abatec.at \
--cc=thomas.petazzoni@bootlin.com \
--cc=tuzakli.refik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox