Re: [Buildroot] [PATCH v2] package/systemd: reenable utmp support

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Casey, All,

On 2023-01-18 20:49 +0100, Casey Reeves spake thusly:
> This patch provides a way to enable utmp support when using systemd,
> with it disabled by default, as some security concerns may apply. Still,
> there are cases where having utmp is desirable, even though it is rare,
> so let's make this configurable.
> 
> See commit 32f53bdfb482d0d78308e548c654898089b5c183.
> 
> Signed-off-by: Casey Reeves <casey@xogium.me>

I've extended the help text with the actual blurb from the systemd-utmp
manpage, and a reference to the upstream URL, like for the other
configurable items.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2:
> - Make this a configurable option rather than hardcode it to forcefully
> disabled or enabled
> ---
>  package/systemd/Config.in  | 16 ++++++++++++++++
>  package/systemd/systemd.mk |  9 +++++++--
>  2 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 45a9e2d644..daa72b65b1 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -518,6 +518,22 @@ config BR2_PACKAGE_SYSTEMD_USERDB
>  
>  	  https://www.freedesktop.org/software/systemd/man/systemd-userdbd.service.html
>  
> +config BR2_PACKAGE_SYSTEMD_UTMP
> +	bool "enable utmp support"
> +	help
> +	  When this feature is selected, systemd will manage the
> +	  support of utmp.
> +
> +	  Utmp keeps track of what users do on the system (where they
> +	  logged from, on which terminal, ...) along with a general
> +	  status of the system (list of reboots, current uptime, current
> +	  number of users logged in).
> +
> +	  You should only enable this if your system requires actual
> +	  users to log in.
> +
> +	  https://man7.org/linux/man-pages/man5/utmp.5.html
> +
>  config BR2_PACKAGE_SYSTEMD_VCONSOLE
>  	bool "enable vconsole tool"
>  	default y
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index b96873b73f..f191542866 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -87,8 +87,7 @@ SYSTEMD_CONF_OPTS += \
>  	-Dtelinit-path= \
>  	-Dtests=false \
>  	-Dtmpfiles=true \
> -	-Dumount-path=/usr/bin/umount \
> -	-Dutmp=false
> +	-Dumount-path=/usr/bin/umount
>  
>  SYSTEMD_CFLAGS = $(TARGET_CFLAGS)
>  ifeq ($(BR2_OPTIMIZE_FAST),y)
> @@ -331,6 +330,12 @@ else
>  SYSTEMD_CONF_OPTS += -Dbinfmt=false
>  endif
>  
> +ifeq ($(BR2_PACKAGE_SYSTEMD_UTMP),y)
> +SYSTEMD_CONF_OPTS += -Dutmp=true
> +else
> +SYSTEMD_CONF_OPTS += -Dutmp=false
> +endif
> +
>  ifeq ($(BR2_PACKAGE_SYSTEMD_VCONSOLE),y)
>  SYSTEMD_CONF_OPTS += -Dvconsole=true
>  else
> -- 
> 2.39.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot