Re: [Buildroot] [PATCH 1/2] support/scripts/graph-depends cleanup done_deps global

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Steve, All,

Thanks for this patch, here a quick review.

On 2023-01-23 00:43 +0100, Steve Hay via buildroot spake thusly:
> From: Steve <me@stevenhay.com>

Please use you full name as author (not just your first name).

Please provide a (potentially terse) explanation for the change.

> Signed-off-by: Steve Hay <me@stevenhay.com>
> ---
>  support/scripts/graph-depends | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
> index a66fb28f41..3e3373950f 100755
> --- a/support/scripts/graph-depends
> +++ b/support/scripts/graph-depends
> @@ -197,12 +197,11 @@ def print_attrs(outfile, pkg, pkg_type, pkg_version, depth, colors):
>      outfile.write("%s [color=%s,style=filled]\n" % (name, color))
>  
>  
> -done_deps = []
> -
> -
>  # Print the dependency graph of a package
>  def print_pkg_deps(outfile, dict_deps, dict_types, dict_versions, stop_list, exclude_list,
> -                   arrow_dir, draw_graph, depth, max_depth, pkg, colors):
> +                   arrow_dir, draw_graph, depth, max_depth, pkg, colors, done_deps=None):

Make the default be the empty list:  done_deps=[]

> +    if done_deps is None:
> +        done_deps = []

... which allows to drop this conditional.

I was wondering how that could work, as the list is now a parameter,
but the list is not passed as a copy, it is passed as a "reference"
in python... So yes, it works (the .dot are the same before/after).

Regards,
Yann E. MORIN.

>      if pkg in done_deps:
>          return
>      done_deps.append(pkg)
> @@ -234,7 +233,7 @@ def print_pkg_deps(outfile, dict_deps, dict_types, dict_versions, stop_list, exc
>                  if draw_graph:
>                      outfile.write("%s -> %s [dir=%s]\n" % (pkg_node_name(pkg), pkg_node_name(d), arrow_dir))
>                  print_pkg_deps(outfile, dict_deps, dict_types, dict_versions, stop_list, exclude_list,
> -                               arrow_dir, draw_graph, depth + 1, max_depth, d, colors)
> +                               arrow_dir, draw_graph, depth + 1, max_depth, d, colors, done_deps)
>  
>  
>  def parse_args():
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot