* [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
@ 2022-12-15 11:18 Neal Frager via buildroot
2023-01-20 11:17 ` Frager, Neal via buildroot
2023-01-24 8:18 ` Luca Ceresoli via buildroot
0 siblings, 2 replies; 6+ messages in thread
From: Neal Frager via buildroot @ 2022-12-15 11:18 UTC (permalink / raw)
To: buildroot; +Cc: michal.simek, luca.ceresoli, thomas.petazzoni, Neal Frager
Reduce the configs in the kria/uboot.fragment to only what is necessary.
This patch has been build and run tested on a kria kv260 starter kit.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- CONFIG_DTB_RESELECT is no longer removed
---
board/zynqmp/kria/uboot.fragment | 4 ----
1 file changed, 4 deletions(-)
diff --git a/board/zynqmp/kria/uboot.fragment b/board/zynqmp/kria/uboot.fragment
index 9e32edfb36..a6a262a562 100644
--- a/board/zynqmp/kria/uboot.fragment
+++ b/board/zynqmp/kria/uboot.fragment
@@ -6,9 +6,5 @@ CONFIG_PHY=y
CONFIG_PHY_XILINX_ZYNQMP=y
CONFIG_PINCTRL=y
CONFIG_PINCONF=y
-CONFIG_POWER_DOMAIN=y
-CONFIG_ZYNQMP_POWER_DOMAIN=y
-CONFIG_DM_RESET=y
-CONFIG_RESET_ZYNQMP=y
CONFIG_VIDEO_ZYNQMP_DPSUB=y
CONFIG_SF_DEFAULT_SPEED=40000000
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
2022-12-15 11:18 [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs Neal Frager via buildroot
@ 2023-01-20 11:17 ` Frager, Neal via buildroot
2023-01-24 8:18 ` Luca Ceresoli via buildroot
1 sibling, 0 replies; 6+ messages in thread
From: Frager, Neal via buildroot @ 2023-01-20 11:17 UTC (permalink / raw)
To: buildroot@buildroot.org
Cc: Simek, Michal, luca.ceresoli@bootlin.com,
thomas.petazzoni@bootlin.com
Hello everyone,
Just a friendly reminder regarding this patch to clean things up a bit.
Best regards,
Neal Frager
AMD
---
Reduce the configs in the kria/uboot.fragment to only what is necessary.
This patch has been build and run tested on a kria kv260 starter kit.
Signed-off-by: Neal Frager <neal.frager@amd.com>
---
V1->V2:
- CONFIG_DTB_RESELECT is no longer removed
---
board/zynqmp/kria/uboot.fragment | 4 ----
1 file changed, 4 deletions(-)
diff --git a/board/zynqmp/kria/uboot.fragment b/board/zynqmp/kria/uboot.fragment
index 9e32edfb36..a6a262a562 100644
--- a/board/zynqmp/kria/uboot.fragment
+++ b/board/zynqmp/kria/uboot.fragment
@@ -6,9 +6,5 @@ CONFIG_PHY=y
CONFIG_PHY_XILINX_ZYNQMP=y
CONFIG_PINCTRL=y
CONFIG_PINCONF=y
-CONFIG_POWER_DOMAIN=y
-CONFIG_ZYNQMP_POWER_DOMAIN=y
-CONFIG_DM_RESET=y
-CONFIG_RESET_ZYNQMP=y
CONFIG_VIDEO_ZYNQMP_DPSUB=y
CONFIG_SF_DEFAULT_SPEED=40000000
--
2.17.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
2022-12-15 11:18 [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs Neal Frager via buildroot
2023-01-20 11:17 ` Frager, Neal via buildroot
@ 2023-01-24 8:18 ` Luca Ceresoli via buildroot
2023-01-24 8:26 ` Frager, Neal via buildroot
1 sibling, 1 reply; 6+ messages in thread
From: Luca Ceresoli via buildroot @ 2023-01-24 8:18 UTC (permalink / raw)
To: Neal Frager; +Cc: michal.simek, thomas.petazzoni, buildroot
Hi Neal,
On Thu, 15 Dec 2022 11:18:31 +0000
Neal Frager <neal.frager@amd.com> wrote:
> Reduce the configs in the kria/uboot.fragment to only what is necessary.
>
> This patch has been build and run tested on a kria kv260 starter kit.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
Apologies for the delay. I was hoping to test this patch, but I'm not
yet there, so for the moment I have a question below.
> ---
> V1->V2:
> - CONFIG_DTB_RESELECT is no longer removed
> ---
> board/zynqmp/kria/uboot.fragment | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/board/zynqmp/kria/uboot.fragment b/board/zynqmp/kria/uboot.fragment
> index 9e32edfb36..a6a262a562 100644
> --- a/board/zynqmp/kria/uboot.fragment
> +++ b/board/zynqmp/kria/uboot.fragment
> @@ -6,9 +6,5 @@ CONFIG_PHY=y
> CONFIG_PHY_XILINX_ZYNQMP=y
> CONFIG_PINCTRL=y
> CONFIG_PINCONF=y
> -CONFIG_POWER_DOMAIN=y
> -CONFIG_ZYNQMP_POWER_DOMAIN=y
> -CONFIG_DM_RESET=y
> -CONFIG_RESET_ZYNQMP=y
Does this prevent the 'reset' command in U-Boot from working?
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
2023-01-24 8:18 ` Luca Ceresoli via buildroot
@ 2023-01-24 8:26 ` Frager, Neal via buildroot
2023-01-27 8:21 ` Luca Ceresoli via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Frager, Neal via buildroot @ 2023-01-24 8:26 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Simek, Michal, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org
Hi Luca,
> Reduce the configs in the kria/uboot.fragment to only what is necessary.
>
> This patch has been build and run tested on a kria kv260 starter kit.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Apologies for the delay. I was hoping to test this patch, but I'm not yet there, so for the moment I have a question below.
No problem.
> ---
> V1->V2:
> - CONFIG_DTB_RESELECT is no longer removed
> ---
> board/zynqmp/kria/uboot.fragment | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/board/zynqmp/kria/uboot.fragment
> b/board/zynqmp/kria/uboot.fragment
> index 9e32edfb36..a6a262a562 100644
> --- a/board/zynqmp/kria/uboot.fragment
> +++ b/board/zynqmp/kria/uboot.fragment
> @@ -6,9 +6,5 @@ CONFIG_PHY=y
> CONFIG_PHY_XILINX_ZYNQMP=y
> CONFIG_PINCTRL=y
> CONFIG_PINCONF=y
> -CONFIG_POWER_DOMAIN=y
> -CONFIG_ZYNQMP_POWER_DOMAIN=y
> -CONFIG_DM_RESET=y
> -CONFIG_RESET_ZYNQMP=y
> Does this prevent the 'reset' command in U-Boot from working?
This patch actually has zero effect on functionality. These 4 u-boot configs are already included in the xilinx_zynqmp_virt_defconfig.
So basically, there was no reason to have these 4 additions in the uboot.fragment file.
This patch removes these configs for the goal of cleaning things up and reducing the uboot.fragment to the minimum.
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
2023-01-24 8:26 ` Frager, Neal via buildroot
@ 2023-01-27 8:21 ` Luca Ceresoli via buildroot
2023-01-27 8:51 ` Frager, Neal via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Luca Ceresoli via buildroot @ 2023-01-27 8:21 UTC (permalink / raw)
To: Frager, Neal
Cc: Simek, Michal, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org
Hi Neal,
On Tue, 24 Jan 2023 08:26:27 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:
> Hi Luca,
>
> > Reduce the configs in the kria/uboot.fragment to only what is necessary.
> >
> > This patch has been build and run tested on a kria kv260 starter kit.
> >
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
>
> > Apologies for the delay. I was hoping to test this patch, but I'm not yet there, so for the moment I have a question below.
>
> No problem.
>
> > ---
> > V1->V2:
> > - CONFIG_DTB_RESELECT is no longer removed
> > ---
> > board/zynqmp/kria/uboot.fragment | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/board/zynqmp/kria/uboot.fragment
> > b/board/zynqmp/kria/uboot.fragment
> > index 9e32edfb36..a6a262a562 100644
> > --- a/board/zynqmp/kria/uboot.fragment
> > +++ b/board/zynqmp/kria/uboot.fragment
> > @@ -6,9 +6,5 @@ CONFIG_PHY=y
> > CONFIG_PHY_XILINX_ZYNQMP=y
> > CONFIG_PINCTRL=y
> > CONFIG_PINCONF=y
> > -CONFIG_POWER_DOMAIN=y
> > -CONFIG_ZYNQMP_POWER_DOMAIN=y
> > -CONFIG_DM_RESET=y
> > -CONFIG_RESET_ZYNQMP=y
>
> > Does this prevent the 'reset' command in U-Boot from working?
>
> This patch actually has zero effect on functionality. These 4 u-boot configs are already included in the xilinx_zynqmp_virt_defconfig.
I see, so the patch is fine. I would add the above line to the
commit message to make it clear. You can send a v3 unless some
maintainers is willing to do it while applying.
With that added:
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs
2023-01-27 8:21 ` Luca Ceresoli via buildroot
@ 2023-01-27 8:51 ` Frager, Neal via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Frager, Neal via buildroot @ 2023-01-27 8:51 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Simek, Michal, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org
Hi Luca,
> Hi Luca,
>
> > Reduce the configs in the kria/uboot.fragment to only what is necessary.
> >
> > This patch has been build and run tested on a kria kv260 starter kit.
> >
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
>
> > Apologies for the delay. I was hoping to test this patch, but I'm not yet there, so for the moment I have a question below.
>
> No problem.
>
> > ---
> > V1->V2:
> > - CONFIG_DTB_RESELECT is no longer removed
> > ---
> > board/zynqmp/kria/uboot.fragment | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/board/zynqmp/kria/uboot.fragment
> > b/board/zynqmp/kria/uboot.fragment
> > index 9e32edfb36..a6a262a562 100644
> > --- a/board/zynqmp/kria/uboot.fragment
> > +++ b/board/zynqmp/kria/uboot.fragment
> > @@ -6,9 +6,5 @@ CONFIG_PHY=y
> > CONFIG_PHY_XILINX_ZYNQMP=y
> > CONFIG_PINCTRL=y
> > CONFIG_PINCONF=y
> > -CONFIG_POWER_DOMAIN=y
> > -CONFIG_ZYNQMP_POWER_DOMAIN=y
> > -CONFIG_DM_RESET=y
> > -CONFIG_RESET_ZYNQMP=y
>
> > Does this prevent the 'reset' command in U-Boot from working?
>
> This patch actually has zero effect on functionality. These 4 u-boot configs are already included in the xilinx_zynqmp_virt_defconfig.
> I see, so the patch is fine. I would add the above line to the commit message to make it clear. You can send a v3 unless some maintainers is willing to do it while applying.
> With that added:
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Thanks. I have created a v3 with a more explicit commit message for your review.
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-27 8:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-15 11:18 [Buildroot] [PATCH v2 1/1] board/zynqmp/kria/uboot.fragment: remove unnecessary configs Neal Frager via buildroot
2023-01-20 11:17 ` Frager, Neal via buildroot
2023-01-24 8:18 ` Luca Ceresoli via buildroot
2023-01-24 8:26 ` Frager, Neal via buildroot
2023-01-27 8:21 ` Luca Ceresoli via buildroot
2023-01-27 8:51 ` Frager, Neal via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox