Re: [Buildroot] [PATCH 1/1] package/gdal: switch to cmake build

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 24 Jan 2023 13:31:49 +0300
Maxim Kochetkov via buildroot <buildroot@buildroot.org> wrote:

> GDAL autoconf has wrong libgeotiff detection. It uses host's
> library if installed instead of buildroot one.
> Modern versions of gdal have no autoconf build scripts, just cmake only.
> 
> So move to cmake build variant.
> 
> Fixes: https://bugs.busybox.net/show_bug.cgi?id=15281

There was a missing empty line here before the Signed-off-by.

> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> ---
>  package/gdal/gdal.mk | 166 ++++++++++++++++++++++---------------------
>  1 file changed, 85 insertions(+), 81 deletions(-)
> 
> diff --git a/package/gdal/gdal.mk b/package/gdal/gdal.mk
> index 33e7ba724a..a777834083 100644
> --- a/package/gdal/gdal.mk
> +++ b/package/gdal/gdal.mk
> @@ -12,6 +12,13 @@ GDAL_LICENSE_FILES = LICENSE.TXT
>  GDAL_CPE_ID_VENDOR = osgeo
>  GDAL_INSTALL_STAGING = YES
>  GDAL_CONFIG_SCRIPTS = gdal-config
> +GDAL_SUPPORTS_IN_SOURCE_BUILD=NO

Missing spaces around "="

> +
> +# Using 'make' with the Makefile generator will not work,
> +# as it will try the GNUmakefile.
> +# GNUmakefile and autoconf are dropped in 3.6 so may be dropped in future version.

I slightly reworded this explanation.

> +GDAL_MAKE_OPTS += -f Makefile
> +
>  # gdal at its core only needs host-pkgconf, libgeotiff, proj and tiff
>  # but since by default mrf driver support is enabled, it also needs
>  # jpeg, libpng and zlib. By default there are also many other drivers
> @@ -20,97 +27,94 @@ GDAL_CONFIG_SCRIPTS = gdal-config
>  # respectively needed dependencies.
>  GDAL_DEPENDENCIES = host-pkgconf jpeg json-c libgeotiff libpng proj tiff zlib
>  
> -# Yes, even though they have --with options, these few libraries are
> +# Yes, even though they have DGDAL_USE, these few libraries are

DGAL_USE should have been "-DGAL_USE options". 

I fixed those minor details, and applied your patch. Thanks a lot!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot