From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: yegorslists--- via buildroot <buildroot@buildroot.org>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v2] package/util-linux: add an option to enable irqtop
Date: Sat, 28 Jan 2023 23:11:27 +0100 [thread overview]
Message-ID: <20230128231127.5ea3c370@windsurf> (raw)
In-Reply-To: <20230117074742.5295-1-yegorslists@googlemail.com>
Hello,
On Tue, 17 Jan 2023 08:47:42 +0100
yegorslists--- via buildroot <buildroot@buildroot.org> wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> irqtop is an IRQ monitoring tool.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes v1 -> v2:
> - add the missing NCURSES dependency
Applied to master, thanks.
Yann: I read your (very valid) concern about the fact that this patch
is changing the behavior of current configurations (irqtop used to be
built unconditionally if all its prerequisites are met, now it is only
built if BR2_PACKAGE_UTIL_LINUX_IRQTOP=y). However, I think the
breakage is very easy to fix, and we need to find the good balance
between backward compatibility and minimal configuration/footprint by
default. In this case, I believe the best trade-off was to make this
new option default to disabled. Note that I realize this is really an
opinion, and there's no perfect solution here.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-01-28 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 7:47 [Buildroot] [PATCH v2] package/util-linux: add an option to enable irqtop yegorslists--- via buildroot
2023-01-28 22:11 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230128231127.5ea3c370@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox