From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] toolchain: make paranoid check of library/header paths unconditional
Date: Sun, 5 Feb 2023 15:00:23 +0100 [thread overview]
Message-ID: <20230205150023.105dfc14@windsurf> (raw)
In-Reply-To: <20221107214903.1565321-1-yann.morin.1998@free.fr>
On Mon, 7 Nov 2022 22:49:03 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> When we introduced support for the paranoid check of unsafe libraries
> and headers path with commit 4ac8f78d3771 (Add option for paranoid
> unsafe path checking) back in 2014, we made it optional, as we expected
> that would break quite a few packages.
>
> Now, almost 8 years later, we only have three packages that explicitly
> reference the option (dillo, gnuradio, and libtalloc), either in a patch
> or in their .mk.
>
> The option has been enabled by default since 2016, with 61c8854cef2a
> (toolchain: enable paranoid unsafe path check by default), and that has
> not triggered many build failures in a while.
>
> The minimal defconfig used by test-pkg has also had it enabled as of
> b6c98b3549d8 (minimal.config: add BR2_COMPILER_PARANOID_UNSAFE_PATH=y)
> in 2017.
>
> It is time to make that globally unconditional now.
>
> There is still a remnant, in our binutils patches. As our toolchain may
> get used outside of Buildroot, people may got the expectation that path
> poisoning is only a warning, so we keep the current behaviour.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Romain Naour <romain.naour@gmail.com>
> ---
> Config.in | 18 ------------------
> package/Makefile.in | 3 +--
> support/config-fragments/minimal.config | 1 -
> toolchain/toolchain-wrapper.c | 21 ++++-----------------
> 4 files changed, 5 insertions(+), 38 deletions(-)
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-05 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 21:49 [Buildroot] [PATCH] toolchain: make paranoid check of library/header paths unconditional Yann E. MORIN
2023-02-05 14:00 ` Thomas Petazzoni via buildroot [this message]
2023-02-05 14:12 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230205150023.105dfc14@windsurf \
--to=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox