Re: [Buildroot] [PATCH next v2 1/7] package/python-idna: set _SETUP_TYPE = flit

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 22 Nov 2022 21:31:24 +0100
Julien Olivain <ju.o@free.fr> wrote:

> Python idna package switched to pyproject.toml in commit:
> https://github.com/kjd/idna/commit/2a00e518efe55d2eeb62cd3f88ace7db41338603
> which is included in idna v3.4.
> 
> When using the old setuptools infra, the package is incorrectly
> installed as v0.0, which is then incorrectly detected by other
> packages when using setuptools pkg_resources.
> 
> The issue can be reproduced with the command:
> 
>     python3 <<EOF
>     __requires__ = ["idna >= 2.5"]
>     import pkg_resources
>     EOF
> 
> which will fail with output:
> 
>     pkg_resources.ContextualVersionConflict: (idna 0.0.0 (/usr/lib/python3.11/site-packages), Requirement.parse('idna>=2.5'), {'hyperlink'})
>     pkg_resources.DistributionNotFound: The 'idna>=2.5' distribution was not found and is required by hyperlink
> 
> This commit changes _SETUP_TYPE to "flit" to fix this issue.
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
> Changes v1 -> v2:
> - Included James' review comment:
>   - _SETUP_TYPE changed from pep517 to flit
> ---
>  package/python-idna/python-idna.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, entire series applied! There was really not much to fix. In one
commit, the runtime test file was forgotten in DEVELOPERS, and in
another, I've added a reference to the upstream commit for the
open(..., "rU") thing.

Thanks a lot for having added relevant runtime tests for all of this,
this is really good!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot