From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] utils/test-pkg: proper output on host without jq installed
Date: Tue, 7 Feb 2023 17:51:09 +0100 [thread overview]
Message-ID: <20230207165109.GJ4124@scaer> (raw)
In-Reply-To: <20221012164831.10476-1-sebastien.szymanski@armadeus.com>
Sébastien, All,
On 2022-10-12 18:48 +0200, Sébastien Szymanski spake thusly:
> On host without jq installed, test-pkg's output is as following:
>
> $ ./utils/test-pkg -p mmc-utils
> bootlin-armv5-uclibc [1/6]: which: no jq in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/14/bin:/usr/lib/llvm/13/bin:/usr/lib64/opencascade/bin)
> JQ IS
> OK
> bootlin-armv7-glibc [2/6]: which: no jq in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/14/bin:/usr/lib/llvm/13/bin:/usr/lib64/opencascade/bin)
> JQ IS
> OK
> bootlin-armv7m-uclibc [3/6]: which: no jq in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/14/bin:/usr/lib/llvm/13/bin:/usr/lib64/opencascade/bin)
> ...
>
> Since test-pkg handles this case we can hide this error message and have
> proper output:
>
> $ ./utils/test-pkg -p mmc-utils
> bootlin-armv5-uclibc [1/6]: OK
> bootlin-armv7-glibc [2/6]: OK
> bootlin-armv7m-uclibc [3/6]: OK
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> utils/test-pkg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/test-pkg b/utils/test-pkg
> index 4ebfd9af66..e7f5464817 100755
> --- a/utils/test-pkg
> +++ b/utils/test-pkg
> @@ -201,7 +201,7 @@ build_one() {
>
> # Validate that we generate proper json as show-info
> { tput smso; printf '>>> Running show-info\n'; tput rmso; } >> "${dir}/logfile" 2> /dev/null;
> - JQ="$(which jq)"
> + JQ="$(which jq 2> /dev/null)"
> if [ -z "${JQ}" ]; then
> make O="${dir}" host-jq >> "${dir}/logfile" 2>&1
> JQ="${dir}/host/bin/jq"
> --
> 2.37.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-07 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 16:48 [Buildroot] [PATCH 1/1] utils/test-pkg: proper output on host without jq installed Sébastien Szymanski
2023-02-07 16:39 ` Romain Naour
2023-02-07 16:51 ` Yann E. MORIN [this message]
2023-02-24 7:35 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207165109.GJ4124@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=sebastien.szymanski@armadeus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox