Re: [Buildroot] [PATCH/next 4/6] package/libsolv: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 28 Nov 2022 12:34:16 +0000
TIAN Yuanhao <tianyuanhao3@163.com> wrote:

> +ifeq ($(BR2_STATIC_LIBS),y)
> +LIBSOLV_CONF_OPTS += -DDISABLE_SHARED=ON
> +else ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> +LIBSOLV_CONF_OPTS += -DENABLE_STATIC=ON
> +endif

Changed to:

ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
LIBSOLV_CONF_OPTS += -DENABLE_STATIC=ON
else
LIBSOLV_CONF_OPTS += -DDISABLE_STATIC=ON
endif

ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
LIBSOLV_CONF_OPTS += -DENABLE_SHARED=ON
else
LIBSOLV_CONF_OPTS += -DDISABLE_SHARED=ON
endif

To explicitly handle all cases.

> +ifeq ($(BR2_PACKAGE_MICROMAMBA),y)
> +LIBSOLV_CONF_OPTS += -DENABLE_CONDA=ON
> +endif

This isn't really nice, as we generally don't want packages to look at
their reverse dependencies to decide which features should be enabled
or not.

So here, I would prefer to have a BR2_PACKAGE_LIBSOLV_CONDA option,
which the micromamba package can select if it needs this feature from
libsolv. For now, I've dropped this part, so if we need it for
micromamba, could you send a patch just adding this new option,
together with the new iteration of the micromamba package?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot