From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nfs-utils: handle pkg-config in the Autotools standard way for nfsrahead
Date: Tue, 7 Feb 2023 18:48:44 +0100 [thread overview]
Message-ID: <20230207184844.7a8dfa82@windsurf> (raw)
In-Reply-To: <20220919224740.2365011-1-giulio.benetti@benettiengineering.com>
On Tue, 20 Sep 2022 00:47:40 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> While using the correct PKG_CHECK_MODULES() approach for libmount we end up
> having host-nfs-utils needing libmount. But libmount is only needed by
> nfsrahead that we don't need in host-nfs-utils. But we need host-nfs-utils
> itself(rpcgen tool specifically) to build nfs-utils. To solve this
> recursive situation:
> 1) Update the first patch with the upstreamed one that handles libmount
> using PKG_CHECK_MODULES().
> 2) Add another patch to allow to disable nfsrahead during building for host
> since this tool is not needed and requires libmount. This way the first
> patch approach can be correctly used.
> 3) Add --disable-nfsrahead to HOST_NFS_UTILS_CONF_OPTS
> 4) Remove en/disable-uuid since now it's required by default:
> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=c5528f40f9db5061e06dcf1f9b7fce5185b376c6
>
> First patch has been committed:
> https://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=627c95b2b853161b359095e7fdf05d3b07d51379
> While the second one is pending:
> https://lore.kernel.org/linux-nfs/20220919221832.2234294-1-giulio.benetti@benettiengineering.com/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> ...ead-fix-linking-while-static-linking.patch | 39 ++++++++---
> ...e.ac-allow-to-disable-nfsrahead-tool.patch | 68 +++++++++++++++++++
> package/nfs-utils/nfs-utils.mk | 7 +-
> 3 files changed, 97 insertions(+), 17 deletions(-)
> create mode 100644 package/nfs-utils/0002-configure.ac-allow-to-disable-nfsrahead-tool.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-07 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 21:51 [Buildroot] [PATCH] package/nfs-utils: improve local patch Giulio Benetti
2022-08-10 23:38 ` [Buildroot] [PATCH v2] " Giulio Benetti
2022-08-11 20:16 ` Petr Vorel
2022-08-11 20:47 ` Thomas Petazzoni via buildroot
2022-09-19 22:47 ` [Buildroot] [PATCH] package/nfs-utils: handle pkg-config in the Autotools standard way for nfsrahead Giulio Benetti
2023-02-07 17:48 ` Thomas Petazzoni via buildroot [this message]
2022-09-19 22:50 ` [Buildroot] [PATCH v2] package/nfs-utils: improve local patch Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207184844.7a8dfa82@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox