From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: romain.naour@smile.fr, Matt Flax <flatmax@flatmax.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5] package/gtkiostream: new package
Date: Tue, 7 Feb 2023 22:51:44 +0100 [thread overview]
Message-ID: <20230207225144.16424f58@windsurf> (raw)
In-Reply-To: <20230207210934.3132539-1-angelo@amarulasolutions.com>
On Tue, 7 Feb 2023 22:09:34 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> +GTKIOSTREAM_VERSION = v1.8.0
> +GTKIOSTREAM_SITE = $(call github,flatmax,gtkiostream,$(GTKIOSTREAM_VERSION))
> +GTKIOSTREAM_LICENSE = GPL-2.0+
> +GTKIOSTREAM_LICENSE_FILES = gpl.txt
> +GTKIOSTREAM_DEPENDENCIES = eigen fftw-double fftw-single host-pkgconf
> +
> +GTKIOSTREAM_DEPENDENCIES += $(if $(BR2_PACKAGE_SOX),sox)
Better written as:
GTKIOSTREAM_DEPENDENCIES = \
eigen \
fftw-double \
...
host-pkgconf \
$(if $(BR2_PACKAGE_SOX),sox)
> +
> +ifeq ($(BR2_PACKAGE_OCTAVE),y)
> +GTKIOSTREAM_DEPENDENCIES += octave
> +GTKIOSTREAM_CONF_OPTS += --enable-octave
> +else
> +GTKIOSTREAM_CONF_OPTS += --disable-octave
> +endif
> +
> +# configure script not available
> +GTKIOSTREAM_AUTORECONF = YES
This normally goes earlier in the makefile, like before the
dependencies/conf_opts.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-07 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 21:09 [Buildroot] [PATCH v5] package/gtkiostream: new package Angelo Compagnucci
2023-02-07 21:50 ` Thomas Petazzoni via buildroot
2023-02-07 21:51 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207225144.16424f58@windsurf \
--to=buildroot@buildroot.org \
--cc=angelo@amarulasolutions.com \
--cc=flatmax@flatmax.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox