Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Angelo Compagnucci <angelo@amarulasolutions.com>
Cc: jesseevg@gmail.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v6 04/13] package/qt6/qt6base: add support for widgets
Date: Wed, 8 Feb 2023 12:09:19 +0100	[thread overview]
Message-ID: <20230208120919.54ed260e@windsurf> (raw)
In-Reply-To: <20230207171721.2973997-5-angelo@amarulasolutions.com>

On Tue,  7 Feb 2023 18:17:12 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> +config BR2_PACKAGE_QT6BASE_WIDGETS
> +	bool "widgets module"
> +	select BR2_PACKAGE_XLIB_LIBXEXT if BR2_PACKAGE_QT6BASE_XCB

According to my build testing, this dependency is not needed, so I
dropped it.

> +	help
> +	  This option enables the Qt6Widgets library.
> +
>  endif
>  
>  config BR2_PACKAGE_QT6BASE_NETWORK
> diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
> index 06ebbab8e7..cf3c7b1ad1 100644
> --- a/package/qt6/qt6base/qt6base.mk
> +++ b/package/qt6/qt6base/qt6base.mk
> @@ -213,6 +213,10 @@ else
>  QT6BASE_CONF_OPTS += -DFEATURE_fontconfig=OFF
>  endif
>  
> +ifeq ($(BR2_PACKAGE_QT6BASE_WIDGETS),y)
> +QT6BASE_CONF_OPTS += -DFEATURE_widgets=ON

Missing else clause to explicitly disable widgets.

Applied with these two things fixed. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-08 11:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 17:17 [Buildroot] [PATCH v6 00/13] Extend Qt6 configuration Angelo Compagnucci
2023-02-07 17:17 ` [Buildroot] [PATCH v6 01/13] package/qt6/qt6base: add support for gui module Angelo Compagnucci
2023-02-08 11:07   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 02/13] package/qt6/qt6base: add support for fontconfig/harfbuzz Angelo Compagnucci
2023-02-08 11:08   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 03/13] package/qt6/qt6base: Add support for jpeg/png/gif image format Angelo Compagnucci
2023-02-08 11:08   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 04/13] package/qt6/qt6base: add support for widgets Angelo Compagnucci
2023-02-08 11:09   ` Thomas Petazzoni via buildroot [this message]
2023-02-07 17:17 ` [Buildroot] [PATCH v6 05/13] package/qt6/qt6base: add support for widgets gtk backend Angelo Compagnucci
2023-02-08 11:09   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 06/13] package/qt6/qt6base: add opengl support Angelo Compagnucci
2023-02-08 11:11   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 07/13] package/qt6/qt6base: add QPA backend selection Angelo Compagnucci
2023-02-08 11:11   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 08/13] package/qt6/qt6base: add support for tslib Angelo Compagnucci
2023-02-08 11:13   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 09/13] package/qt6/qt6base: add support for libinput Angelo Compagnucci
2023-02-08 11:13   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 10/13] package/qt6/qt6base: add support for kms Angelo Compagnucci
2023-02-08 11:13   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 11/13] package/qt6/qt6base: add support for printsupport/cups Angelo Compagnucci
2023-02-08 11:15   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 12/13] package/qt6/qt6base: add support for building examples Angelo Compagnucci
2023-02-08 11:16   ` Thomas Petazzoni via buildroot
2023-02-07 17:17 ` [Buildroot] [PATCH v6 13/13] package/qt6: Add qmake functionality Angelo Compagnucci
2023-02-08 11:18   ` Thomas Petazzoni via buildroot
2023-02-10 10:14     ` Jesse Van Gavere

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230208120919.54ed260e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=angelo@amarulasolutions.com \
    --cc=jesseevg@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox