From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B96CC61DA4 for ; Sat, 11 Feb 2023 09:51:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F11114031E; Sat, 11 Feb 2023 09:51:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F11114031E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6-I1tid-nopz; Sat, 11 Feb 2023 09:51:44 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 25272402E0; Sat, 11 Feb 2023 09:51:43 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 25272402E0 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id DA5C61BF279 for ; Sat, 11 Feb 2023 09:51:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C1A3E81C2F for ; Sat, 11 Feb 2023 09:51:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org C1A3E81C2F X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o8_qH0BensYA for ; Sat, 11 Feb 2023 09:51:40 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8696381B70 Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [212.27.42.5]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8696381B70 for ; Sat, 11 Feb 2023 09:51:40 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [171.22.1.1]) (Authenticated sender: yann.morin.1998@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 7241E5FFAF; Sat, 11 Feb 2023 10:51:35 +0100 (CET) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sat, 11 Feb 2023 10:51:35 +0100 Date: Sat, 11 Feb 2023 10:51:35 +0100 From: "Yann E. MORIN" To: Romain Naour Message-ID: <20230211095135.GD2796@scaer> References: <20230211094202.3816592-1-romain.naour@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230211094202.3816592-1-romain.naour@gmail.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1676109097; bh=yOj13GFhjxMbNkSoNk9AzGxEgRsc6nTLZPCUtpuVwLA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r7BHS+I4yet94B2AdXct/hXmTcZ5GJ3tSRT7yRpgYW3sgMsyRocamjwMT48AKdmFQ tDhPHeu6CkA6IYnK9pGFDGgf9NKBZQinAATXB6U75UCRgoRgGdyezzDDNcKVV9FgQA MfFQ0R81XSuAq2cPHsKjzOublu5aGFPORONnhb34EtgARuxhIP0m76sL4eoo3Aoc13 szyPW5BkqpGYryeMJcFNoqOPNDVSoVczW815mOPOBxWlXUMvJkme+Fywazn8eERFcS aqGU/XccUk0n61O/fx3kZ2/jw2GO75ADvyA8PW+dPilci8BZcTO0ez4myXokWybKeO iR2rxqtVxXEVg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=r7BHS+I4 Subject: Re: [Buildroot] [PATCH] package/pkg-waf: add missing $ X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Romain. All, On 2023-02-11 10:42 +0100, Romain Naour spake thusly: > We want to have $(@D) expanded at the time the recipe is run, so like > all other variables, we need to $$-expand it. > > Fixes: > http://autobuild.buildroot.org/results/b6f/b6fd3a866af182edc7831492aecc8323f377b826 Thanks for the quick fix, but se below... > Signed-off-by: Romain Naour > Cc: Yann E. MORIN > Cc: Peter Korsgaard > --- > package/pkg-waf.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/pkg-waf.mk b/package/pkg-waf.mk > index 0e752072c8..c3e965bdf3 100644 > --- a/package/pkg-waf.mk > +++ b/package/pkg-waf.mk > @@ -42,7 +42,7 @@ define inner-waf-package > # otherwise waf errors out with: > # Waf script 'X' and library 'Y' do not match > define WAF_PACKAGE_REMOVE_WAF_LIB > - $(RM) -fr $(@D)/waf $(@D)/waflib > + $(RM) -fr $$(@D)/waf $$(@D)/waflib Shouldn't we be using $$($$(PKG)_SRCDIR) or $$($(2)_SRCDIR) instead of $$(@D), like is used everywhere else in the file: cd $$($$(PKG)_SRCDIR) && python3 configure [...] cd $$($$(PKG)_SRCDIR) && python3 $$($(2)_WAF) (Note that last one uses a mix of $$(PKG) and $(2)...) Regards, Yann E. MORIN. > endef > > # We need host-python3 to run waf > -- > 2.34.3 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot