From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/olsr: fix build with gpsd >= 3.25
Date: Sun, 12 Feb 2023 17:49:03 +0100 [thread overview]
Message-ID: <20230212164903.GO2796@scaer> (raw)
In-Reply-To: <20230212130336.373391-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2023-02-12 14:03 +0100, Fabrice Fontaine spake thusly:
> Fix the following build failure with gpsd >= 3.25 raised since commit
> 3c7fece853f3def9a425eccc384b9dacb1010051:
[--SNIP--]
> +Signed-off-by: Rui Chen <rui@chenrui.dev>
> +[Retrieved from: https://github.com/OLSR/olsrd/pull/119]
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +---
> + lib/pud/src/gpsdclient.h | 8 --------
> + 1 file changed, 8 deletions(-)
> +
> +diff --git a/lib/pud/src/gpsdclient.h b/lib/pud/src/gpsdclient.h
> +index 061056b12..a51dd2211 100644
> +--- a/lib/pud/src/gpsdclient.h
> ++++ b/lib/pud/src/gpsdclient.h
> +@@ -60,14 +60,6 @@ struct GpsdConnectionState {
> + struct devconfig_t dev[MAXUSERDEVS];
> + };
> +
> +-/* describe a data source */
> +-struct fixsource_t {
> +- char spec[PATH_MAX]; /* working space, will be modified */
> +- char *server; /* pointer into spec field */
> +- char *port; /* pointer into spec field */
> +- char *device; /* pointer into spec field */
> +-};
Given that this breaks the build with older gpsd versions, I suspect
this is not goign to be accepted by upstream.
I've sent another proposal to fix that issue in a backward compatible
manner:
https://github.com/OLSR/olsrd/pull/120
Let's see a bit what upstream decides.
Regards,
Yann E. MORIN.
> + /**
> + * The gpsd daemon spec
> + */
> --
> 2.39.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-12 16:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 13:03 [Buildroot] [PATCH 1/1] package/olsr: fix build with gpsd >= 3.25 Fabrice Fontaine
2023-02-12 16:49 ` Yann E. MORIN [this message]
2023-09-30 17:10 ` Peter Korsgaard
2023-10-13 6:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230212164903.GO2796@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox