From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: TIAN Yuanhao <tianyuanhao3@163.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/libsolv: drop unrecognized variables
Date: Sun, 12 Feb 2023 21:35:16 +0100 [thread overview]
Message-ID: <20230212203516.GS2796@scaer> (raw)
In-Reply-To: <20230212144316.1181860-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2023-02-12 15:43 +0100, Fabrice Fontaine spake thusly:
> Drop unrecognized variables:
>
> CMake Warning:
> Manually-specified variables were not used by the project:
>
> BUILD_DOC
> BUILD_DOCS
> BUILD_EXAMPLE
> BUILD_EXAMPLES
> BUILD_TEST
> BUILD_TESTING
> BUILD_TESTS
> CMAKE_CXX_COMPILER_FORCED
> DISABLE_STATIC
> ENABLE_SHARED
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Both patches applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/libsolv/libsolv.mk | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/libsolv/libsolv.mk b/package/libsolv/libsolv.mk
> index 29f8a6a3d2..04fdb387fd 100644
> --- a/package/libsolv/libsolv.mk
> +++ b/package/libsolv/libsolv.mk
> @@ -11,16 +11,15 @@ LIBSOLV_LICENSE_FILES = LICENSE.BSD
> LIBSOLV_CPE_ID_VENDOR = opensuse
> LIBSOLV_INSTALL_STAGING = YES
> LIBSOLV_DEPENDENCIES = zlib
> -LIBSOLV_CONF_OPTS = -DCMAKE_CXX_COMPILER_FORCED=ON
>
> ifeq ($(BR2_STATIC_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
> LIBSOLV_CONF_OPTS += -DENABLE_STATIC=ON
> else
> -LIBSOLV_CONF_OPTS += -DDISABLE_STATIC=ON
> +LIBSOLV_CONF_OPTS += -DENABLE_STATIC=OFF
> endif
>
> ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
> -LIBSOLV_CONF_OPTS += -DENABLE_SHARED=ON
> +LIBSOLV_CONF_OPTS += -DDISABLE_SHARED=OFF
> else
> LIBSOLV_CONF_OPTS += -DDISABLE_SHARED=ON
> endif
> --
> 2.39.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-12 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-12 14:43 [Buildroot] [PATCH 1/2] package/libsolv: drop unrecognized variables Fabrice Fontaine
2023-02-12 14:43 ` [Buildroot] [PATCH 2/2] package/libsolv: fix build without C++ Fabrice Fontaine
2023-02-12 20:35 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230212203516.GS2796@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=tianyuanhao3@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox