From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next v2 2/2] package/libjxl: new package
Date: Mon, 13 Feb 2023 23:22:35 +0100 [thread overview]
Message-ID: <20230213232235.63bbc016@windsurf> (raw)
In-Reply-To: <20221124220552.2836398-2-ju.o@free.fr>
Hello Julien,
On Thu, 24 Nov 2022 23:05:52 +0100
Julien Olivain <ju.o@free.fr> wrote:
> libjxl is the reference implementation of JPEG XL (encoder and decoder).
>
> https://github.com/libjxl/libjxl
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Thanks, I've applied with some small changes, see below.
> diff --git a/package/libjxl/Config.in b/package/libjxl/Config.in
> new file mode 100644
> index 0000000000..6a15bde107
> --- /dev/null
> +++ b/package/libjxl/Config.in
> @@ -0,0 +1,23 @@
> +config BR2_PACKAGE_LIBJXL
> + bool "libjxl"
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # highway
> + depends on BR2_TOOLCHAIN_HAS_ATOMIC # highway
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> + depends on BR2_INSTALL_LIBSTDCPP # highway
> + # libjxl fail to link statically due to libatomic issue
> + depends on !BR2_STATIC_LIBS
> + # GCC bug on sh4: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81426
> + depends on !BR2_sh4
Changed to use a new BR2_TOOLCHAIN_HAS_GCC_BUG_81426 blind option.
> + select BR2_PACKAGE_BROTLI
> + select BR2_PACKAGE_HIGHWAY
> + select BR2_PACKAGE_LCMS2
> + help
> + libjxl is the reference implementation of JPEG XL (encoder
> + and decoder).
> +
> + https://github.com/libjxl/libjxl
> +
> +comment "libjxl needs a toolchain with C++, threads, gcc >= 7"
> + depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
> + !BR2_INSTALL_LIBSTDCPP || \
> + !BR2_TOOLCHAIN_HAS_THREADS
This was not complete: you have 6 "depends on" above, so 6 depends on
should be handled here one way or another:
comment "libjxl needs a toolchain with C++, threads, gcc >= 7, dynamic library"
depends on BR2_TOOLCHAIN_HAS_ATOMIC
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_81426
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
!BR2_INSTALL_LIBSTDCPP || \
!BR2_TOOLCHAIN_HAS_THREADS || \
BR2_STATIC_LIBS
Applied with that change. Thanks a lot for the runtime tests, very
useful as usual!
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-13 22:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 22:05 [Buildroot] [PATCH next v2 1/2] package/highway: new package Julien Olivain
2022-11-24 22:05 ` [Buildroot] [PATCH next v2 2/2] package/libjxl: " Julien Olivain
2023-02-13 22:22 ` Thomas Petazzoni via buildroot [this message]
2023-02-13 22:20 ` [Buildroot] [PATCH next v2 1/2] package/highway: " Thomas Petazzoni via buildroot
2023-02-14 23:20 ` Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213232235.63bbc016@windsurf \
--to=buildroot@buildroot.org \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox