Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Gero Schwäricke" <gero@schwaericke.email>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] board/cubietech/cubieboard1: add Cubieboard 1
Date: Fri, 17 Feb 2023 16:15:21 +0100	[thread overview]
Message-ID: <20230217161521.01f4f2a7@windsurf> (raw)
In-Reply-To: <20221105194712.541286-1-gero@schwaericke.email>

Hello Gero,

On Sat,  5 Nov 2022 19:47:12 +0000
Gero Schwäricke <gero@schwaericke.email> wrote:

> Board support for the Cubieboard 1 from Cubietech. Based the config for
> Cubieboard 2 and the Olimex A10-OLinuXino-LIME which is also an
> Allwinner A10 board (sunxi kernel).
> 
> Signed-off-by: Gero Schwäricke <gero@schwaericke.email>

First of all, thanks a lot for your contribution, and sorry for the
very slow feedback. See below some feedback.

First of all, the commit title should be:

	configs/cubieboard1: new defconfig

> ---
>  board/cubietech/cubieboard1/boot.cmd     |  7 +++++
>  board/cubietech/cubieboard1/genimage.cfg | 36 ++++++++++++++++++++++
>  configs/cubieboard1_defconfig            | 39 ++++++++++++++++++++++++
>  3 files changed, 82 insertions(+)
>  create mode 100644 board/cubietech/cubieboard1/boot.cmd
>  create mode 100644 board/cubietech/cubieboard1/genimage.cfg
>  create mode 100644 configs/cubieboard1_defconfig

Could you add an entry in the DEVELOPERS file, both for the
board/cubietech/cubieboard1/ folder and for the
configs/cubieboard1_defconfig file?

Another thing that is missing is a
board/cubietech/cubieboard1/readme.txt that explains how to use this
defconfig on this particular board.

> diff --git a/board/cubietech/cubieboard1/boot.cmd b/board/cubietech/cubieboard1/boot.cmd
> new file mode 100644
> index 0000000000..eefbdc8169
> --- /dev/null
> +++ b/board/cubietech/cubieboard1/boot.cmd
> @@ -0,0 +1,7 @@
> +# based on board/cubieboard2/boot.cmd
> +
> +setenv fdt_high ffffffff
> +setenv bootargs console=ttyS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait
> +fatload mmc 0 $kernel_addr_r zImage
> +fatload mmc 0 $fdt_addr_r sun4i-a10-cubieboard.dtb
> +bootz $kernel_addr_r - $fdt_addr_r

There's no support for extlinux.conf in the default U-Boot
configuration for this board?

Otherwise, it all looks good to me. Could you address the minor issues
listed here, and send a 2nd version of your patch?

Thanks a lot!

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-17 15:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 19:47 [Buildroot] [PATCH] board/cubietech/cubieboard1: add Cubieboard 1 Gero Schwäricke
2023-02-17 15:15 ` Thomas Petazzoni via buildroot [this message]
2023-08-09 18:16   ` Gero Schwäricke
2023-08-10 20:48 ` [Buildroot] [PATCH v2] configs/cubieboard1: new defconfig Gero Schwäricke
2024-02-05  9:44   ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217161521.01f4f2a7@windsurf \
    --to=buildroot@buildroot.org \
    --cc=gero@schwaericke.email \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox