Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff via buildroot <buildroot@buildroot.org>
Cc: Robert Rose <robertroyrose@gmail.com>
Subject: Re: [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0
Date: Sun, 19 Feb 2023 22:02:17 +0100	[thread overview]
Message-ID: <20230219220217.6b34a65f@windsurf> (raw)
In-Reply-To: <20230218114837.1761715-1-buildroot@heine.tech>

Hello Michael,

On Sat, 18 Feb 2023 12:48:37 +0100
Michael Nosthoff via buildroot <buildroot@buildroot.org> wrote:

> libabseil now depends on c++14 and gcc >= 7.3.1 [0][1]
> 
> [0] https://github.com/abseil/abseil-cpp/releases/tag/20230125.0
> [1] https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md
> 
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
> 
> Note:
> I'm not sure if the BR2_TOOLCHAIN_GCC_AT_LEAST_7 dependency is sufficient.
> But I don't think we have a more version specific Flag available?

We don't have more specific blind options than 7.x, 8.x, etc. to
describe a gcc dependency.

>  package/grpc/Config.in                   | 6 +++---
>  package/libabseil-cpp/Config.in          | 6 +++---
>  package/libabseil-cpp/libabseil-cpp.hash | 2 +-
>  package/libabseil-cpp/libabseil-cpp.mk   | 6 +++---
>  4 files changed, 10 insertions(+), 10 deletions(-)

I'm afraid this is not sufficient. Indeed, you need to look at the
reverse dependencies of GRPC for example.

So, package/falcosecurity-libs needs to be adjusted, then
package/sysdig as well, and also the BR2_PACKAGE_COLLECTD_GRPC option
from package/collectd.

Could you have a look into this, and submit an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-19 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18 11:48 [Buildroot] [PATCH] packge/libabseil-cpp: bump to version 20230125.0 Michael Nosthoff via buildroot
2023-02-19 21:02 ` Thomas Petazzoni via buildroot [this message]
2023-02-20  7:48   ` Michael Nosthoff via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230219220217.6b34a65f@windsurf \
    --to=buildroot@buildroot.org \
    --cc=robertroyrose@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox