From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Alexey Lukyanchuk <skif@skif-web.ru>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/zabbix: fix libcurl build
Date: Mon, 20 Feb 2023 21:44:23 +0100 [thread overview]
Message-ID: <20230220214423.1a42a0e5@windsurf> (raw)
In-Reply-To: <20230220093336.77462-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Mon, 20 Feb 2023 10:33:36 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fix the following libcurl build failure:
>
> In file included from /tmp/instance-1/output-1/host/s390x-buildroot-linux-gnu/sysroot/usr/include/curl/curl.h:3195,
> from ../../../../include/sysinc.h:384,
> from ../../../../include/common.h:23,
> from simple.c:20:
> simple.c: In function 'check_https':
> simple.c:167:65: error: invalid use of void expression
> 167 | if (CURLE_OK != (err = curl_easy_setopt(easyhandle, opt = CURLOPT_USERAGENT, "Zabbix " ZABBIX_VERSION)) ||
> | ^
>
> Fixes:
> - http://autobuild.buildroot.org/results/053a62e9969046a7f8a0e1890c24d2bfb099ae42
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...se-parentheses-to-ensure-compilation.patch | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 package/zabbix/0002-Use-parentheses-to-ensure-compilation.patch
This was reported to curl upstream in
https://github.com/curl/curl/issues/10148, and apparently fixed in curl
by
https://github.com/curl/curl/commit/e2aed004302e51cfa5b6ce8c8ab65ef92aa83196.
So it apparently was considered a bug in curl, so perhaps it should be
fixed in curl rather than in zabbix?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-20 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 9:33 [Buildroot] [PATCH 1/1] package/zabbix: fix libcurl build Fabrice Fontaine
2023-02-20 20:44 ` Thomas Petazzoni via buildroot [this message]
2023-02-24 11:21 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220214423.1a42a0e5@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=skif@skif-web.ru \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox