From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Julien Olivain <ju.o@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/3] package/libjxl: fix build with libjpeg
Date: Mon, 20 Feb 2023 21:51:11 +0100 [thread overview]
Message-ID: <20230220215111.19dcba5d@windsurf> (raw)
In-Reply-To: <20230219140051.80647-1-fontaine.fabrice@gmail.com>
On Sun, 19 Feb 2023 15:00:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Building with libjpeg will raise the following build failure on some
> architectures since the addition of the package in commit
> e648d399d8bd609697e78f13f7fa76be06d91a57:
>
> /tmp/instance-14/output-1/build/libjxl-0.7.0/lib/extras/enc/jpg.cc: In function 'jxl::Status jxl::extras::{anonymous}::EncodeWithLibJpeg(const jxl::extras::PackedImage&, const JxlBasicInfo&, const std::vector<unsigned char>&, std::vector<unsigned char>, size_t, const string&, std::vector<unsigned char>*)':
> /tmp/instance-14/output-1/build/libjxl-0.7.0/lib/extras/enc/jpg.cc:126:34: error: invalid conversion from 'long unsigned int*' to 'size_t*' {aka 'unsigned int*'} [-fpermissive]
> 126 | jpeg_mem_dest(&cinfo, &buffer, &size);
> | ^~~~~
> | |
> | long unsigned int*
>
> Upstream advocates to use jpeg-turbo:
> https://github.com/libjxl/libjxl/issues/1802
>
> Fixes:
> - http://autobuild.buildroot.org/results/9a2a7c6072876f2562609bf98f32a1ce93631a75
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/libjxl/libjxl.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
To be honest, I find quite ugly the fact that only jpeg-turbo is
supported, but it indeed seems like libjpeg and jpeg-turbo are not 100%
compatible, unfortunately.
So: entire series applied, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-20 20:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 14:00 [Buildroot] [PATCH 1/3] package/libjxl: fix build with libjpeg Fabrice Fontaine
2023-02-19 14:00 ` [Buildroot] [PATCH 2/3] package/libjxl: disable benchmark and tests Fabrice Fontaine
2023-02-19 14:00 ` [Buildroot] [PATCH 3/3] package/libjxl: security bump to version 0.8.1 Fabrice Fontaine
2023-02-19 15:37 ` Julien Olivain
2023-02-19 15:30 ` [Buildroot] [PATCH 1/3] package/libjxl: fix build with libjpeg Julien Olivain
2023-02-19 16:37 ` Fabrice Fontaine
2023-02-20 20:51 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220215111.19dcba5d@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox