From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Frank Vanbever <frank.vanbever@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3, 1/1] package/libmodsecurity: needs dynamic library with libcurl, libssh2 and mbedtls
Date: Mon, 20 Feb 2023 21:55:31 +0100 [thread overview]
Message-ID: <20230220215531.7b3a1783@windsurf> (raw)
In-Reply-To: <20230219172440.519540-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Sun, 19 Feb 2023 18:24:40 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Commit 9fc652a373034118535397fdd4042ab9f8fd7adf was incomplete as
> mbedtls can be pulled in libcurl through libssh2 resulting in the
> following build failure:
>
> /home/autobuild/autobuild/instance-4/output-1/host/lib/gcc/powerpc64le-buildroot-linux-musl/11.3.0/../../../../powerpc64le-buildroot-linux-musl/bin/ld: /home/autobuild/autobuild/instance-4/output-1/host/powerpc64le-buildroot-linux-musl/sysroot/usr/lib//libmbedcrypto.a(md5.c.o): in function `mbedtls_md5_init':
> md5.c:(.text+0x0): multiple definition of `mbedtls_md5_init'; ../../src/.libs/libmodsecurity.a(libmbedtls_la-md5.o):md5.c:(.text+0x0): first defined here
>
> Fixes:
> - http://autobuild.buildroot.org/results/4c235e46188f23d1a48297f4e5942cec7b25959a
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3:
> - Fix syntax
> Changes v1 -> v2:
> - Update nginx-modsecurity
Isn't that a bit madness? If libmodsecurity has its copy of parts of
mbedtls, but didn't take care of renaming the symbols, then ultimately
what we should conclude is that using libmodsecurity in a statically
linked configuration is not supported.
So I would advocate for simplifying the whole thing and just make
libmodsecurity and its reverse dependencies depends on !BR2_STATIC_LIBS
and be done with it.
What do you think?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-20 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 17:24 [Buildroot] [PATCH v3, 1/1] package/libmodsecurity: needs dynamic library with libcurl, libssh2 and mbedtls Fabrice Fontaine
2023-02-20 20:55 ` Thomas Petazzoni via buildroot [this message]
2023-02-20 22:31 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220215531.7b3a1783@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=frank.vanbever@mind.be \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox