From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Frank Vanbever <frank.vanbever@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4, 1/1] package/libmodsecurity: needs dynamic library
Date: Tue, 21 Feb 2023 09:32:15 +0100 [thread overview]
Message-ID: <20230221093215.419fcf40@windsurf> (raw)
In-Reply-To: <20230220223151.12965-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Mon, 20 Feb 2023 23:31:51 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> diff --git a/package/libmodsecurity/Config.in b/package/libmodsecurity/Config.in
> index b15d808759..2186d216f4 100644
> --- a/package/libmodsecurity/Config.in
> +++ b/package/libmodsecurity/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_LIBMODSECURITY
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS
> # libmodsecurity embeds several mbedtls source files
I've expanded a bit this comment, as it was not very clear why this
causes problem with static linking.
> - depends on !(BR2_STATIC_LIBS && BR2_PACKAGE_LIBCURL_MBEDTLS)
> + depends on !BR2_STATIC_LIBS
> select BR2_PACKAGE_PCRE2
> help
> comment "nginx-modsecurity needs a toolchain w/ C++, threads"
> depends on BR2_PACKAGE_NGINX_HTTP
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
> -
> -comment "nginx-modsecurity needs a toolchain w/ dynamic library"
> - depends on BR2_PACKAGE_NGINX_HTTP
> - depends on BR2_STATIC_LIBS && BR2_PACKAGE_LIBCURL_MBEDTLS
> + depends on !BR2_INSTALL_LIBSTDCPP || \
> + !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
Something was wrong here: you forgot to update the comment prompt
itself to mention the dependency on dynamic library.
I fixed both minor issues and applied to master. Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-21 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 22:31 [Buildroot] [PATCH v4, 1/1] package/libmodsecurity: needs dynamic library Fabrice Fontaine
2023-02-21 8:32 ` Thomas Petazzoni via buildroot [this message]
2023-03-05 17:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221093215.419fcf40@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=frank.vanbever@mind.be \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox