Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Norbert Lange <nolange79@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/dbus-broker: bump to release 33
Date: Tue, 21 Feb 2023 09:43:29 +0100	[thread overview]
Message-ID: <20230221094329.79cf0b8e@windsurf> (raw)
In-Reply-To: <29cebb7af48c3652e440c61cc90fafa4fe3f8046.1676300324.git.stefan@agner.ch>

Hello Stefan,

On Mon, 13 Feb 2023 15:58:57 +0100
Stefan Agner <stefan@agner.ch> wrote:

> This release contains mostly a bugfixes, with some improvements around
> error handling for unimplemented functionality and resiliency against
> runtime changes of dbus service-files.
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>

Thanks a lot for the update. However see below for a comment.

> ---
>  package/dbus-broker/dbus-broker.hash | 6 +++---
>  package/dbus-broker/dbus-broker.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/dbus-broker/dbus-broker.hash b/package/dbus-broker/dbus-broker.hash
> index f6c2cbe160..06c8f229b7 100644
> --- a/package/dbus-broker/dbus-broker.hash
> +++ b/package/dbus-broker/dbus-broker.hash
> @@ -1,5 +1,5 @@
>  # Locally calculated
> -sha256  bea7f653e7251063c5f427e9e3f93562d38a0d8667ae6d49fb56f113605985de  dbus-broker-32.tar.xz
> +sha256  23713f25624749fdb274907e429080fa2d8f4dbe76acd87bb6d21a3c818c7841  dbus-broker-33.tar.xz
>  sha256  3cda3630283eda0eab825abe5ac84d191248c6b3fe1c232a118124959b96c6a4  LICENSE
>  sha256  20ea1f96abc15553695c6725bb3dcabff4b43b85b7ca7d675a2b8860e3b01f87  subprojects/libcdvar-1/AUTHORS
>  sha256  8153c478102dc209b30dd4627cf5bb3596263f99692bf3eec174b1e17bbf8a3b  subprojects/libcdvar-1/README.md
> @@ -11,7 +11,7 @@ sha256  23f24eeaaded5fedd6e7840b6f7b73838f9a4e2112ad6a12fe1ef958f73d0214  subpro
>  sha256  05113a24aca4c537819dd0d91b95b13edb85bea4b6a77a6d9269becb397ed374  subprojects/libcrbtree-3/README.md
>  sha256  6d63b1fb794d4c02622595ad30357c90398aa883864e5a275479139c8f03208f  subprojects/libcshquote-1/AUTHORS
>  sha256  cad109dd33062518a437ebee145ba863fe0e047d4e3db9c28b0bf3c6148f10c2  subprojects/libcshquote-1/README.md
> -sha256  32913ba08dc041f3f4ca361fc0d68014120e1c612772aabbcc901556df499ce5  subprojects/libcstdaux-1/AUTHORS
> -sha256  7c4b6c325b0bc02150089112f65132ee999b0f44500b73d1fc06d96c93161037  subprojects/libcstdaux-1/README.md
> +sha256  e796182869fe0892347d069f3f423774124987d6c45d016854fc51530633c177  subprojects/libcstdaux-1/AUTHORS
> +sha256  92006886d7f28894fef08bf97e35ef52147067bd3c4d4d6381da7c59f9901dae  subprojects/libcstdaux-1/README.md

When there are changes in the license files, we need to have a short
explanation in the commit log about these. Indeed, if we simply
"blindly" update the hashes, then having those hashes in the first
place is completely useless: the whole point of having hashes for
license files is to detect changes in the license files, analyze them
and justify if they require or not a change in how the licensing of the
package is described in Buildroot.

Could you resend with an updated commit message that explain the
changes in the license files? Even if they are minimal/trivial, having
this explanation in the commit log will help the reviewers/maintainers
to make sure the changes in those license files have been verified.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-21  8:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13 14:58 [Buildroot] [PATCH v2] package/dbus-broker: bump to release 33 Stefan Agner
2023-02-21  8:43 ` Thomas Petazzoni via buildroot [this message]
2023-02-28  7:19   ` Stefan Agner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221094329.79cf0b8e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=nolange79@gmail.com \
    --cc=stefan@agner.ch \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox