From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 656D5C61DA3 for ; Tue, 21 Feb 2023 20:04:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id EE36D408D2; Tue, 21 Feb 2023 20:04:18 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org EE36D408D2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oc3WNfumJ7nR; Tue, 21 Feb 2023 20:04:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 218B7405F5; Tue, 21 Feb 2023 20:04:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 218B7405F5 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 3D28A1BF362 for ; Tue, 21 Feb 2023 20:04:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0E43881980 for ; Tue, 21 Feb 2023 20:04:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0E43881980 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JRkVbVfdnlRe for ; Tue, 21 Feb 2023 20:04:13 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 915CC80C03 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by smtp1.osuosl.org (Postfix) with ESMTPS id 915CC80C03 for ; Tue, 21 Feb 2023 20:04:13 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 8696E1BF206; Tue, 21 Feb 2023 20:04:11 +0000 (UTC) Date: Tue, 21 Feb 2023 21:04:10 +0100 To: Giulio Benetti Message-ID: <20230221210410.61bd1054@windsurf> In-Reply-To: <20230221183051.4011311-1-giulio.benetti@benettiengineering.com> References: <20230221183051.4011311-1-giulio.benetti@benettiengineering.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1677009851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qqM/R0TWuIwN0yZ02vC+WOFkfJLXSJQ/QbBCYQrWxLs=; b=EK+u/5I/mqR5VOdzmLc9QBM7HTikiyGpmxAkk09RVFFpau0SRcckLBxi3mlP3Mdekuc8tc uluBbCG+o7MgQh+fOJNyEzfS5ojH5cz6UQrpSRDNbtDIMMD5TbvvlTRoukYrnoIUbHiGA4 +QQKBV+PSxxg0YEWbfDtSsZC+m4D3x8jqQVZ52uavRpixIJTD6CnMnFLZjZDk+9FUoyeAq IsC98K30dgNL4XkWOHt9+YziyIj4D3Xx+o//5BbPqXcqSKmCfA/L/b2scRds+/r0zAqY2+ jlgtyNz99vfViEDJTQIEsGyheu6SBuzsgSjfFBQbMF8aCEwNrMBZNJInMH1hIQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=EK+u/5I/ Subject: Re: [Buildroot] [PATCH] package/jpeg: fix build failure when qt5base tries to use libjpeg X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Tue, 21 Feb 2023 19:30:51 +0100 Giulio Benetti wrote: > Qt5 fails to build with libjpeg since the API is different from > libjpeg-turbo and libjpeg-turbo is pointed as the library Qt5 usually link > against to[0]. So let's default jpeg variant to libjpeg-turbo if > BR2_PACKAGE_QT5BASE_JPEG is selected. > > Fixes: > still not failed > > [0]: https://doc.qt.io/qt-5/qtgui-index.html#licenses-and-attributions > > Signed-off-by: Giulio Benetti > --- > package/jpeg/Config.in | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/package/jpeg/Config.in b/package/jpeg/Config.in > index 371f89aa49..3a39a0dfb8 100644 > --- a/package/jpeg/Config.in > +++ b/package/jpeg/Config.in > @@ -16,7 +16,8 @@ if BR2_PACKAGE_JPEG > > choice > prompt "jpeg variant" > - default BR2_PACKAGE_JPEG_TURBO if BR2_PACKAGE_JPEG_SIMD_SUPPORT > + default BR2_PACKAGE_JPEG_TURBO if BR2_PACKAGE_JPEG_SIMD_SUPPORT || \ > + BR2_PACKAGE_QT5BASE_JPEG I don't think this will work, as it doesn't prevent from using classic libjpeg with Qt5, it only changes the default. So a user can still select Qt5 + classic libjpeg, and the autobuilder randomization will also generate such configurations. If really classic libjpeg are jpeg-turbo are no longer compatible, then we probably need to drop the virtual package entirely... but it's going to be a lot of work to handle both variants in all packages using jpeg... Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot