From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: AndreiCherniaev <cherniaev.andrei@kairo.space>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] boot/grub2: add information where is configuration file
Date: Tue, 21 Feb 2023 23:01:55 +0100 [thread overview]
Message-ID: <20230221230155.0e21a186@windsurf> (raw)
In-Reply-To: <20230109073353.11701-1-cherniaev.andrei@kairo.space>
Hello Andrei,
On Mon, 9 Jan 2023 16:33:52 +0900
AndreiCherniaev <cherniaev.andrei@kairo.space> wrote:
> diff --git a/boot/grub2/Config.in b/boot/grub2/Config.in
> index 92b5dd501b..bf0400c08f 100644
> --- a/boot/grub2/Config.in
> +++ b/boot/grub2/Config.in
> @@ -125,6 +125,7 @@ config BR2_TARGET_GRUB2_BUILTIN_CONFIG_PC
> into the Grub image itself. This allows to set the root
> device and other configuration parameters, but however menu
> entries cannot be described in this embedded configuration.
> + Use boot/grub2/grub.cfg to edit menu entries.
Actually no, you probably don't want to change boot/grub2/grub.cfg: it
is part of Buildroot itself, and you probably don't want to have
project-specific changes in there.
Instead, you should override it using a rootfs overlay (if grub.cfg is
in $(TARGET_DIR)/boot) or a post-build/post-image script (if it's in
the EFI partition).
I have nevertheless applied your patch, but after tweaking the message
in the help text, and moving it to the main Grub2 option. See:
https://gitlab.com/buildroot.org/buildroot/-/commit/7692d5beb2d9e4d0b463f0f26a177829e5bcc1ec
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-02-21 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 7:33 [Buildroot] [PATCH] boot/grub2: add information where is configuration file AndreiCherniaev
2023-02-21 22:01 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221230155.0e21a186@windsurf \
--to=buildroot@buildroot.org \
--cc=cherniaev.andrei@kairo.space \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox