From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6232AC61DA4 for ; Thu, 23 Feb 2023 06:41:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1266681FC9; Thu, 23 Feb 2023 06:41:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1266681FC9 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P2JtQfdHSCQK; Thu, 23 Feb 2023 06:41:37 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 1DC3481FA8; Thu, 23 Feb 2023 06:41:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1DC3481FA8 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5CD461BF842 for ; Thu, 23 Feb 2023 06:41:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 371314040D for ; Thu, 23 Feb 2023 06:41:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 371314040D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Km6frQfj1XDC for ; Thu, 23 Feb 2023 06:41:34 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 38827402EB Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [IPv6:2a01:e0c:1:1599::14]) by smtp2.osuosl.org (Postfix) with ESMTPS id 38827402EB for ; Thu, 23 Feb 2023 06:41:34 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [171.22.1.1]) (Authenticated sender: yann.morin.1998@free.fr) by smtp5-g21.free.fr (Postfix) with ESMTPSA id 572B55FF88; Thu, 23 Feb 2023 07:41:29 +0100 (CET) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Thu, 23 Feb 2023 07:41:29 +0100 Date: Thu, 23 Feb 2023 07:41:29 +0100 From: "Yann E. MORIN" To: Fabrice Fontaine Message-ID: <20230223064129.GL2718518@scaer> References: <20230222143512.1555539-1-fontaine.fabrice@gmail.com> <20230223062259.GJ2718518@scaer> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230223062259.GJ2718518@scaer> User-Agent: Mutt/1.5.22 (2013-10-16) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1677134491; bh=JO86KPuVtBzf2s57uLzKF2+4Dqo75jrivqxaaStpHPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FBipY0J8tKsblpZAQM8Ii5YbNvX5rjZrGkzjGkE2h3ye2AakvaE8XtRYUuxpmb3lj ZpHPaj4YoA2vcNLxN9MEbSS6TXB4N/VS8Rf4AX+rFiGXU8tuc0uzbtzolwV7gPhPxR 29BdDuizjizwMeFduZ/PWZmcan2dQr904si2aY92O6DuXVzL+0f7fzI5fUoH3+C4zs VJSiiWPXHC9F7KLEjO60+uLtwY4HwftrgstnCUM8MevytvcQhzVw0GASVsKFa4Preq 5Rp3SXx/SJ6MRdvaPJ49Zic+SUy40jXGKn1OhrcLYeDnJNcarphxoGKTiJpJ/PnHc7 AUbYCOnQAiYXA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=FBipY0J8 Subject: Re: [Buildroot] [PATCH 1/1] package/audit: force arm mode instead of Thumb mode X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Fabrice, All, On 2023-02-23 07:22 +0100, Yann E. MORIN spake thusly: > On 2023-02-22 15:35 +0100, Fabrice Fontaine spake thusly: > > Fix the following build failure: > > > > /tmp/ccY5gl3z.s:2145: Error: selected processor does not support `mcr p15,0,r2,c7,c10,5' in Thumb mode > > > > Fixes: > > - http://autobuild.buildroot.org/results/9d18a0d360b2e2f9e87c55daedda62d6ce198bb9 > > > > Signed-off-by: Fabrice Fontaine > > --- > > package/audit/audit.mk | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/package/audit/audit.mk b/package/audit/audit.mk > > index cbb174b980..af81dabac0 100644 > > --- a/package/audit/audit.mk > > +++ b/package/audit/audit.mk > > @@ -15,6 +15,13 @@ AUDIT_INSTALL_STAGING = YES > > > > AUDIT_CONF_OPTS = --without-python --without-python3 > > > > +# src/libev has some assembly function that is not present in Thumb mode: > > +# Error: selected processor does not support `mcr p15,0,r3,c7,c10,5' in Thumb mode > > +# so, we desactivate Thumb mode > > +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y) > > +AUDIT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -marm" > > +endif > > But then it would not work on systems that have a armv7m: BR2_cortex_m3, > BR2_cortex_m4, or BR2_cortex_m7. > > I looked at the code, and it's going to be very complex to patch it to > support armv7m, i.e. thumb-only. > > So, we will have to disallow audit in this case. It is going to be easy, > as it already have a _ARCH_SUPPORTS, but it going to neeed a bit of > cleanup: > > config BR2_PACKAGE_AUDIT_ARCH_SUPPORTS > bool > default y if BR2_aarch64 > default y if (BR2_arm || BR2_armeb) && BR2_ARM_CPU_HAS_ARM As I wrote in the libev review for the same issue, the condition is a bit more complex: default y if (BR2_arm || BR2_armeb) && (BR2_ARM_CPU_HAS_ARM || BR2_ARM_CPU_HAS_THUMB2) Regards, Yann E. MORIN. > default y if BR2_i386 || BR2_x86_64 > default y if BR2_powerpc || BR2_powerpc64 > > And then, the only 'select' is from libsemanage, which already depends > on AUDIT_ARCH_SUPPORT, so all is going to be alright (in the end). > > Regards, > Yann E. MORIN. > > > ifeq ($(BR2_PACKAGE_LIBCAP_NG),y) > > AUDIT_DEPENDENCIES += libcap-ng > > AUDIT_CONF_OPTS += --with-libcap-ng=yes > > -- > > 2.39.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot