Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Adrian Perez de Castro <aperez@igalia.com>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>,
	Thomas Devoogdt <thomas.devoogdt@barco.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 4/4] package/libgtk3: fix update-icon-cache on empty directory
Date: Sat, 25 Feb 2023 10:52:10 +0100	[thread overview]
Message-ID: <20230225105210.248b646a@windsurf> (raw)
In-Reply-To: <20230223125612.3156012-1-thomas.devoogdt@barco.com>

Hello Thomas,

On Thu, 23 Feb 2023 13:56:12 +0100
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> If both, hicolor-icon-theme (selected by libgtk3-demo) and
> adwaita-icon-theme is not selected, then the /usr/share/icons
> folder is empty, causing find to fail.
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Thanks for this work on gtk!

Could you please always resend complete series, even if only one patch
is changed? Otherwise, it's super confusing. We see just PATCH 4/4 in
version 4, and we wonder if the other patches (1/4, 2/4, 3/4) were lost.

> @@ -146,6 +146,7 @@ endef
>  # Create icon-theme.cache for each of the icon directories/themes
>  # It's not strictly necessary but speeds up lookups
>  define LIBGTK3_UPDATE_ICON_CACHE
> +[ ! -d $(TARGET_DIR)/usr/share/icons ] || \

Indentation is not correct, this line should be indented with one tab.

>  	find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
>  		-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
>  endef

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-25  9:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20  9:09 [Buildroot] [PATCH v1 1/3] Revert "xorg-server: not available with musl on ARM" Thomas Devoogdt
2023-02-20  9:09 ` [Buildroot] [PATCH v1 2/3] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
2023-02-20 17:22   ` Peter Korsgaard
2023-02-20 18:53     ` Thomas Devoogdt
2023-02-20 20:03       ` Peter Korsgaard
2023-02-20 20:49     ` Thomas Petazzoni via buildroot
2023-02-20 20:57       ` Peter Korsgaard
2023-02-21 15:52         ` Thomas Devoogdt
2023-02-21 19:27           ` [Buildroot] [PATCH v3 1/4] package/at-spi2-core: bump to version 2.47.1 Thomas Devoogdt
2023-02-21 19:28             ` [Buildroot] [PATCH v3 2/4] package/at-spi2-atk: remove package Thomas Devoogdt
2023-02-21 19:28             ` [Buildroot] [PATCH v3 3/4] package/atk: " Thomas Devoogdt
2023-02-21 19:28             ` [Buildroot] [PATCH v3 4/4] package/libgtk3: only update-icon-cache when the demos are built Thomas Devoogdt
2023-02-23  6:58               ` François Perrad
2023-02-23  8:01                 ` Thomas Devoogdt
2023-02-23 12:56                   ` [Buildroot] [PATCH v4 4/4] package/libgtk3: fix update-icon-cache on empty directory Thomas Devoogdt
2023-02-25  9:52                     ` Thomas Petazzoni via buildroot [this message]
2023-02-20  9:09 ` [Buildroot] [PATCH v1 3/3] package/webkitgtk: security bump to version 2.38.5 Thomas Devoogdt
2023-02-20  9:29   ` Adrian Perez de Castro
2023-02-20 13:01     ` Thomas Devoogdt
2023-02-20 13:27       ` Adrian Perez de Castro
2023-02-20 17:22   ` Peter Korsgaard
2023-02-20 17:17 ` [Buildroot] [PATCH v1 1/3] Revert "xorg-server: not available with musl on ARM" Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230225105210.248b646a@windsurf \
    --to=buildroot@buildroot.org \
    --cc=aperez@igalia.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.devoogdt@barco.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox