Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gwenhael Goavec-Merou <gwenj@trabucayre.com>
To: "Vincent Stehlé via buildroot" <buildroot@buildroot.org>
Cc: "Jean Burgat" <jeanburgat33@gmail.com>,
	"Vincent Stehlé" <vincent.stehle@laposte.net>
Subject: Re: [Buildroot] [PATCH next] package/openfpgaloader: fix typos
Date: Mon, 6 Mar 2023 22:29:18 +0100	[thread overview]
Message-ID: <20230306222918.2aab2c4f@x230> (raw)
In-Reply-To: <20230306211646.3717-1-vincent.stehle@laposte.net>

On Mon,  6 Mar 2023 22:16:46 +0100
Vincent Stehlé via buildroot <buildroot@buildroot.org> wrote:

> Fix a typo in the name of two configuration options.
> This repairs the selection of libgpiod support.
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Jean Burgat <jeanburgat33@gmail.com>
> ---
> 
> 
> Hi,
> 
> The fix for the BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD has a functional change
> and is applicable to the next branch only.
> 
> The fix for the BR2_PACKAGE_OPENFPGALOADER_CMSIS is also applicable to the
> master branch if desired, but as it has no functional effect I think it is not
> that urgent.
> 
> Best regards,
> Vincent.
> 
> 
>  package/openfpgaloader/Config.in         | 2 +-
>  package/openfpgaloader/openfpgaloader.mk | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/openfpgaloader/Config.in
> b/package/openfpgaloader/Config.in index 4ba01d12d3..bd83ad415b 100644
> --- a/package/openfpgaloader/Config.in
> +++ b/package/openfpgaloader/Config.in
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_OPENFPGALOADER
>  
>  if BR2_PACKAGE_OPENFPGALOADER
>  
> -config BR2_PACAKGE_OPENFPGALOADER_CMSIS
> +config BR2_PACKAGE_OPENFPGALOADER_CMSIS
>  	bool "CMSIS-DAP support"
>  	depends on BR2_PACKAGE_HAS_UDEV # hidapi
>  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # hidapi
> diff --git a/package/openfpgaloader/openfpgaloader.mk
> b/package/openfpgaloader/openfpgaloader.mk index 042b16612e..6d7fbd9850 100644
> --- a/package/openfpgaloader/openfpgaloader.mk
> +++ b/package/openfpgaloader/openfpgaloader.mk
> @@ -17,14 +17,14 @@ else
>  OPENFPGALOADER_CONF_OPTS += -DENABLE_UDEV=OFF
>  endif
>  
> -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_CMSIS),y)
> +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_CMSIS),y)
>  OPENFPGALOADER_DEPENDENCIES += hidapi
>  OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=ON
>  else
>  OPENFPGALOADER_CONF_OPTS += -DENABLE_CMSISDAP=OFF
>  endif
>  
> -ifeq ($(BR2_PACAKGE_OPENFPGALOADER_LIBGPIOD),y)
> +ifeq ($(BR2_PACKAGE_OPENFPGALOADER_LIBGPIOD),y)
>  OPENFPGALOADER_DEPENDENCIES += libgpiod
>  OPENFPGALOADER_CONF_OPTS += -DENABLE_LIBGPIOD=ON
>  else
> -- 
Acked-by: Gwenhael Goavec-merou <gwenhael.goavec-merou@trabucayre.com>

Thanks!

Regards

Gwen
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-03-06 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 21:16 [Buildroot] [PATCH next] package/openfpgaloader: fix typos Vincent Stehlé via buildroot
2023-03-06 21:29 ` Gwenhael Goavec-Merou [this message]
2023-03-12  9:07 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230306222918.2aab2c4f@x230 \
    --to=gwenj@trabucayre.com \
    --cc=buildroot@buildroot.org \
    --cc=jeanburgat33@gmail.com \
    --cc=vincent.stehle@laposte.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox