From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Martin Hundebøll" <martin@geanix.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] ifupdown: bump to 0.8.41
Date: Sun, 12 Mar 2023 22:43:26 +0100 [thread overview]
Message-ID: <20230312224326.68a1f832@windsurf> (raw)
In-Reply-To: <20230223104048.333575-1-martin@geanix.com>
Hello Martin,
Thanks for this contribution!
On Thu, 23 Feb 2023 11:40:48 +0100
Martin Hundebøll <martin@geanix.com> wrote:
> From: Martin Hundeboll <martin@geanix.com>
>
> Musl is not supported since June 2017, where use of fnmatch() was
> introduced to support wildcard matching on interfaces.
>
> Signed-off-by: Martin Hundebøll <martin@geanix.com>
I find it a bit annoying to disable a package as simple/core as
ifupdown with musl.
Alpine Linux has two patches at
https://git.alpinelinux.org/aports/tree/main/ifupdown?h=master that
address the build issue by disabling the use of FNM_EXTMATCH with musl.
Since this only adds additional wildcard matching capabilities, it
works fine without.
Perhaps ifupdown should simply be improved to use FNM_EXTMATCH if
supported?
In any case, if we want to indeed add the !musl dependency like your
patch does, the Config.in comment needs to be adjusted to account for
the !musl dependency.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-03-12 21:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 10:40 [Buildroot] [PATCH] ifupdown: bump to 0.8.41 Martin Hundebøll
2023-03-12 21:43 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230312224326.68a1f832@windsurf \
--to=buildroot@buildroot.org \
--cc=martin@geanix.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox