Re: [Buildroot] [PATCH 1/1] package/openocd: bump to 0.12.0

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Roman Passler <roman.passler@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openocd: bump to 0.12.0
Date: Mon, 13 Mar 2023 22:54:31 +0100	[thread overview]
Message-ID: <20230313225431.45802c0f@windsurf> (raw)
In-Reply-To: <20230313183235.2665-1-roman.passler@gmail.com>

Hello Roman,

Thanks for your contribution! Some comments below.

On Mon, 13 Mar 2023 19:32:35 +0100
Roman Passler <roman.passler@gmail.com> wrote:

> Change-Id: Ie76a4f365af3f59c80241fe4935129d1098b140d

Not a big deal, but we don't need/want a Change-Id in commit logs of
Buildroot commits. If you can easily avoid adding one, it would be
great.

> Signed-off-by: Roman Passler <roman.passler@gmail.com>
> ---
>  package/openocd/openocd.hash | 6 +++---
>  package/openocd/openocd.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/openocd/openocd.hash b/package/openocd/openocd.hash
> index 91eb56d930..325f55bf04 100644
> --- a/package/openocd/openocd.hash
> +++ b/package/openocd/openocd.hash
> @@ -1,3 +1,3 @@
> -# From http://sourceforge.net/projects/openocd/files/openocd/0.11.0/
> -sha256  43a3ce734aff1d3706ad87793a9f3a5371cb0e357f0ffd0a151656b06b3d1e7d  openocd-0.11.0.tar.bz2
> -sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
> +# From http://sourceforge.net/projects/openocd/files/openocd/0.12.0/
> +sha256  af254788be98861f2bd9103fe6e60a774ec96a8c374744eef9197f6043075afa  openocd-0.12.0.tar.bz2
> +sha256  1b8f7e37ee5afbbf95c2a4d62b12b25232e29538692663b434318503a9a88419  COPYING

Could you please add an explanation in the commit log about why the
hash of the license file is changed?

Indeed, we precisely have such hashes to detect changes in the
licensing terms, analyze them and check how they affect the overall
licensing of the package. So if the hash is "blindly" changed, having a
hash doesn't make sense in the first place. Therefore, we ask to have a
short note in the commit log that justifies the change of license file
hash.

Could you have a look into this, and send a 2nd version?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot