Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/swugenerator: new package
Date: Tue, 14 Mar 2023 08:59:47 +0100	[thread overview]
Message-ID: <20230314085947.231281ad@windsurf> (raw)
In-Reply-To: <20230313221705.1121868-1-giulio.benetti@benettiengineering.com>

Hello Giulio,

Thanks for this new package.

On Mon, 13 Mar 2023 23:17:05 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> +SWUGENERATOR_VERSION = 0.2
> +SWUGENERATOR_SITE = https://github.com/sbabic/swugenerator/archive/refs/tags/v$(SWUGENERATOR_VERSION)

Could you please use the $(call github,...,...,...) macro here?

> +SWUGENERATOR_LICENSE = GPL-3.0
> +SWUGENERATOR_LICENSE_FILES = LICENSE
> +HOST_SWUGENERATOR_SETUP_TYPE = setuptools
> +
> +$(eval $(host-python-package))

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-03-14  7:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 22:17 [Buildroot] [PATCH] package/swugenerator: new package Giulio Benetti
2023-03-14  7:59 ` Thomas Petazzoni via buildroot [this message]
2023-03-14 12:30   ` [Buildroot] [PATCH v2] " Giulio Benetti
2023-03-14 22:37     ` Thomas Petazzoni via buildroot
2023-03-15  9:40       ` Giulio Benetti
2023-03-15 10:08       ` [Buildroot] [PATCH v2 1/2] package/python-libconf: " Giulio Benetti
2023-03-15 10:08         ` [Buildroot] [PATCH v2 2/2] package/swugenerator: " Giulio Benetti
2023-03-15 10:13           ` Giulio Benetti
2023-07-30 21:53           ` Thomas Petazzoni via buildroot
2023-07-30 21:53         ` [Buildroot] [PATCH v2 1/2] package/python-libconf: " Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230314085947.231281ad@windsurf \
    --to=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox