From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
Marcus Folkesson <marcus.folkesson@gmail.com>,
buildroot@buildroot.org,
"Yann E . MORIN" <yann.morin.1998@free.fr>,
Ricardo Martincoski <ricardo.martincoski@gmail.com>,
Pascal de Bruijn <p.debruijn@unilogic.nl>
Subject: Re: [Buildroot] [PATCH 1/3] package/kodi/br-kodi: fix shellcheck warnings
Date: Sat, 18 Mar 2023 23:03:34 +0100 [thread overview]
Message-ID: <20230318230334.7a73d654@windsurf> (raw)
In-Reply-To: <20230317202724.79207-1-ju.o@free.fr>
Hello Julien,
On Fri, 17 Mar 2023 21:27:22 +0100
Julien Olivain <ju.o@free.fr> wrote:
> When running "make check-package" on a system with shellcheck 0.9.0,
> the command fails with output:
Thing is our "reference" shellcheck version is 0.7.1, from our
reference Docker container:
$ ./utils/docker-run shellcheck --version
ShellCheck - shell script analysis tool
version: 0.7.1
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Since shellcheck warnings vary between versions, I'm not sure we want
to handle warnings from all possible shellcheck versions.
At least I remember that when Ricardo added the ignore list of
warnings, he did mention that it would be important to settle on a
specific version of shellcheck.
Of course, I'm all open to updating the Docker container to use a newer
version of shellcheck, but what I meant is that we should consistently
use the same version.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-03-18 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 20:27 [Buildroot] [PATCH 1/3] package/kodi/br-kodi: fix shellcheck warnings Julien Olivain
2023-03-17 20:27 ` [Buildroot] [PATCH 2/3] package/linux-tools/S10hyperv: " Julien Olivain
2023-03-18 22:05 ` Thomas Petazzoni via buildroot
2023-03-17 20:27 ` [Buildroot] [PATCH 3/3] utils/config: " Julien Olivain
2023-03-18 22:03 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318230334.7a73d654@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd.kuhls@t-online.de \
--cc=ju.o@free.fr \
--cc=marcus.folkesson@gmail.com \
--cc=p.debruijn@unilogic.nl \
--cc=ricardo.martincoski@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox