Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Herve Codina via buildroot <buildroot@buildroot.org>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/linux-tools: add USB tools (testusb and ffs-test)
Date: Fri, 24 Mar 2023 11:09:46 +0100	[thread overview]
Message-ID: <20230324110946.5c275439@bootlin.com> (raw)
In-Reply-To: <20230324093307.1255640-1-luca.ceresoli@bootlin.com>

Hi Luca,

On Fri, 24 Mar 2023 10:33:07 +0100
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> Extend the linux-tools package to also build the userspace USB tools, which
> currently include testusb and ffs-test.
> 
> These tools are in the kernel tree since a long time, but a Makefile was
> added only in 5.9 to allow building in the same way as other tools provided
> with the kernel. Here we use the Makefile and thus version >= 5.9 is
> required. Support for older kernels may be added later if needed.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
[...]
> +
> +ifeq ($(BR2_PACKAGE_LINUX_TOOLS_USBTOOLS_TESTUSB),)
> +define USBTOOLS_INSTALL_REMOVE_TESTUSB
> +	$(RM) -rf $(TARGET_DIR)/usr/bin/testusb

Why -r ?

> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_LINUX_TOOLS_USBTOOLS_FFSTEST),)
> +define USBTOOLS_INSTALL_REMOVE_FFSTEST
> +	$(RM) -rf $(TARGET_DIR)/usr/bin/ffs-test

Same here

> +endef
> +endif
> +

Otherwise, looks good for me.

Thanks for this patch,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-03-24 10:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-24  9:33 [Buildroot] [PATCH] package/linux-tools: add USB tools (testusb and ffs-test) Luca Ceresoli via buildroot
2023-03-24 10:09 ` Herve Codina via buildroot [this message]
2023-03-24 10:13   ` Thomas Petazzoni via buildroot
2023-03-24 10:27 ` yann.morin
2023-03-27 13:57   ` Luca Ceresoli via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324110946.5c275439@bootlin.com \
    --to=buildroot@buildroot.org \
    --cc=herve.codina@bootlin.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox