From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Raphael Pavlidis <raphael.pavlidis@gmail.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build
Date: Sun, 26 Mar 2023 14:18:05 +0200 [thread overview]
Message-ID: <20230326141805.310d6e67@windsurf> (raw)
In-Reply-To: <20230325175815.24876-1-raphael.pavlidis@gmail.com>
On Sat, 25 Mar 2023 18:58:15 +0100
Raphael Pavlidis <raphael.pavlidis@gmail.com> wrote:
> Add a patch to fix the build if only yescrypt is enabled.
>
> Fixes:
> - http://autobuild.buildroot.net/results/df6a16a55bf02cf2d7377f9636913f0b3bca574f
> - http://autobuild.buildroot.net/results/758d4fd297fbd77ef846d3a3d4c207021f866752
> Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> ---
> ...-sflg-for-USE_YESCRYPT-in-newusers.c.patch | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
>
> diff --git a/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch b/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
> new file mode 100644
> index 0000000000..6c2a15d898
> --- /dev/null
> +++ b/package/shadow/0001-Define-sflg-for-USE_YESCRYPT-in-newusers.c.patch
> @@ -0,0 +1,29 @@
> +From 8f7d5e8adae3aa16c0e3a4cb5db34d6764aa0495 Mon Sep 17 00:00:00 2001
> +From: Raphael Pavlidis <raphael.pavlidis@gmail.com>
> +Date: Thu, 23 Mar 2023 19:16:12 +0100
> +Subject: [PATCH v1 1/1] Define sflg for USE_YESCRYPT in newusers.c
> +
> +If only yescrypt is used then the boolean sflg is not defined, but it is
> +access. Therefore, it causes a build error.
> +
> +Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>
Thanks for fixing this! Has this patch been submitted to the upstream
shadow project?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-03-26 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 17:58 [Buildroot] [PATCH v1 1/1] package/shadow: only yescrypt build Raphael Pavlidis
2023-03-26 12:18 ` Thomas Petazzoni via buildroot [this message]
2023-04-04 18:31 ` Raphael Pavlidis
2023-05-26 19:16 ` Raphael Pavlidis
[not found] ` <eb8cf642-62ed-3f32-a32e-f7d28fd6998f__26834.4457073667$1685128600$gmane$org@gmail.com>
2023-07-14 16:54 ` Bernd Kuhls
2023-07-29 22:15 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326141805.310d6e67@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=raphael.pavlidis@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox