Re: [Buildroot] [PATCH v1 2/2] boot/uboot.mk: new BR2_TARGET_UBOOT_NEEDS_ZYNQMP_FIRMWARE

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Sun, 26 Mar 2023 15:09:49 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> The new BR2_TARGET_UBOOT_NEEDS_ZYNQMP_FIRMWARE option will enable u-boot to
> use the zynqmp-firmware package for building a pmufw.elf that gets included in
> the generated boot.bin.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  boot/uboot/Config.in | 11 +++++++++++
>  boot/uboot/uboot.mk  |  5 +++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
> index f5c20f5168..116df71ea3 100644
> --- a/boot/uboot/Config.in
> +++ b/boot/uboot/Config.in
> @@ -476,6 +476,17 @@ config BR2_TARGET_UBOOT_ZYNQMP
>  
>  if BR2_TARGET_UBOOT_ZYNQMP
>  
> +config BR2_TARGET_UBOOT_NEEDS_ZYNQMP_FIRMWARE
> +	bool "U-Boot needs zynqmp-firmware"

I think this naming is confusing. If I understand correctly, U-Boot now
offers two possibilities:

(1) Using a prebuild PMU firmware (this is what is currently possible
    in Buildroot)

(2) Building the PMU firmware from source (which is what your patch is
    adding)

I believe the proposed option naming/organization doesn't make this
very clear. I don't have a super clear idea of what it should look
like. Perhaps we should have a choice...endchoice that makes it 100%
clear that the user can chose between using a pre-built vs. building
one from source?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot