From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag
Date: Tue, 28 Mar 2023 21:37:33 +0200 [thread overview]
Message-ID: <20230328193733.GA3204460@scaer> (raw)
In-Reply-To: <20230327141122.103829-1-luca.ceresoli@bootlin.com>
Luca, All,
On 2023-03-27 16:11 +0200, Luca Ceresoli spake thusly:
> The value of the RM variable in make is 'rm -f', thus the additional -f is
> redundant.
I've added a pointer to the documentation:
https://www.gnu.org/software/make/manual/make.html#index-RM
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Both applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/linux-tools/linux-tool-perf.mk.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/linux-tools/linux-tool-perf.mk.in b/package/linux-tools/linux-tool-perf.mk.in
> index dda63cccecb4..5431c78152c5 100644
> --- a/package/linux-tools/linux-tool-perf.mk.in
> +++ b/package/linux-tools/linux-tool-perf.mk.in
> @@ -166,8 +166,8 @@ endef
> # target unless BR2_PACKAGE_LINUX_TOOLS_PERF_SCRIPTS is enabled
> ifeq ($(BR2_PACKAGE_LINUX_TOOLS_PERF_SCRIPTS),)
> define PERF_INSTALL_REMOVE_SCRIPTS
> - $(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/scripts/
> - $(RM) -rf $(TARGET_DIR)/usr/libexec/perf-core/tests/
> + $(RM) -r $(TARGET_DIR)/usr/libexec/perf-core/scripts/
> + $(RM) -r $(TARGET_DIR)/usr/libexec/perf-core/tests/
> endef
> endif
>
> --
> 2.34.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-03-28 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 14:11 [Buildroot] [PATCH 1/2] package/linux-tools: perf: ditch redundant -f 'rm' flag Luca Ceresoli via buildroot
2023-03-27 14:11 ` [Buildroot] [PATCH 2/2] docs/manual: " Luca Ceresoli via buildroot
2023-03-28 19:38 ` Yann E. MORIN
2023-03-29 6:43 ` Luca Ceresoli via buildroot
2023-04-10 19:24 ` Peter Korsgaard
2023-03-28 19:37 ` Yann E. MORIN [this message]
2023-04-10 19:24 ` [Buildroot] [PATCH 1/2] package/linux-tools: perf: " Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328193733.GA3204460@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=luca.ceresoli@bootlin.com \
--cc=thomas.de_schampheleire@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox