Re: [Buildroot] [PATCH] package/bluez5_utils: Fix builds with musl-libc

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Florian, All,

On 2023-03-26 06:09 -0700, Florian Fainelli spake thusly:
> Backport upstream commit ca6546fe521360fcf905bc115b893f322e706cb2
> ("shared: define MAX_INPUT for musl") to fix builds with musl-libc.
> 
> Fixes:
> - http://autobuild.buildroot.net/results/3fd24a604a29eff70e20f82690e3f058f04903f9/
> - http://autobuild.buildroot.net/results/bd57f1813be699cd5ce2ae94f5f511a71fe10428/
> - http://autobuild.buildroot.net/results/90d528cc18a367af2f68e1c0673d962fe399e1ac/
> - http://autobuild.buildroot.net/results/552b700ee129e1c7f651de13f6766eae5325dcbc/
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  .../bluez5_utils/0001-musl-max-input.patch    | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 package/bluez5_utils/0001-musl-max-input.patch
> 
> diff --git a/package/bluez5_utils/0001-musl-max-input.patch b/package/bluez5_utils/0001-musl-max-input.patch
> new file mode 100644
> index 000000000000..87fbb68f8f40
> --- /dev/null
> +++ b/package/bluez5_utils/0001-musl-max-input.patch
> @@ -0,0 +1,35 @@
> +From ca6546fe521360fcf905bc115b893f322e706cb2 Mon Sep 17 00:00:00 2001
> +From: Sam James <sam@gentoo.org>
> +Date: Tue, 31 Jan 2023 05:52:58 +0000
> +Subject: shared: define MAX_INPUT for musl
> +
> +musl systems don't have MAX_INPUT. Just define it to _POSIX_MAX_INPUT
> +which musl does have if it's not already defined.
> +
> +Note that on glibc, the values match anyway (as of glibc-2.36), and
> +indeed POSIX_MAX_INPUT has the same value on musl too.
> +
> +Bug: https://bugs.gentoo.org/888467

Please add your SoB to this patch, and a note that it is a blackport
(yes, the commit log mentions it is a backport, but when we need to
assess this patch in the future, having the notre in the patch itself is
much easier). I usually do that with a note like:

    Original commit log...

    [yann.morin.1998@free.fr: backport from upstream]
    Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Note: if the path header has the upstream commit sha1 and applies as-is
(possibly with just a bit of fuzz), then "backport from upstream" is
enough. But if you had to rewrite the ptch, and the header does not have
the upstream sha1, then add it to the note:

    [yann.morin.1998@free.fr: backport and adapt from upsteam 1234CDEF]

The most important missing part here that I can't add is your SoB, so
can you please respin?

Regards,
Yann E. MORIN.

> +---
> + src/shared/util.c | 5 +++++
> + 1 file changed, 5 insertions(+)
> +
> +diff --git a/src/shared/util.c b/src/shared/util.c
> +index 2f0ae0e86..b466fb001 100644
> +--- a/src/shared/util.c
> ++++ b/src/shared/util.c
> +@@ -28,6 +28,11 @@
> + #include <sys/random.h>
> + #endif
> + 
> ++/* define MAX_INPUT for musl */
> ++#ifndef MAX_INPUT
> ++#define MAX_INPUT _POSIX_MAX_INPUT
> ++#endif
> ++
> + #include "src/shared/util.h"
> + 
> + void *util_malloc(size_t size)
> +-- 
> +cgit 
> +
> -- 
> 2.34.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot