Re: [Buildroot] [PATCH v2 1/2] package/zynqmp-firmware: new package

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hi Neal,

On Mon, 27 Mar 2023 18:06:03 +0100
Neal Frager <neal.frager@amd.com> wrote:

> This patch adds a new package to buildroot for building the zynqmp pmufw
> with the requirement that the user must provide an external microblaze
> toolchain.
> 
> The below example config options can be used to build the pmufw.elf v2022.2
> using the Xilinx toolchain.
> 
> BR2_PACKAGE_ZYNQMP_FIRMWARE=y
> BR2_PACKAGE_ZYNQMP_FIRMWARE_VERSION="v2022.2"
> BR2_PACKAGE_ZYNQMP_FIRMWARE_EXTERNAL_TOOLCHAIN_PATH="/opt/Xilinx/Vitis/2022.2/gnu/microblaze/lin"
> BR2_PACKAGE_ZYNQMP_FIRMWARE_EXTERNAL_TOOLCHAIN_PREFIX="microblaze-xilinx-elf-"
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

These two patches look good, and I appreciate a lot your effort, however
I'm not sure it's a good idea to support both an external and a
generated toolchain. It makes things more complicated on the Buildroot
side and I'm not aware of any actual benefits.

Moreover if we take these patches now we would to some extent encourage
users to use an external Microblaze toolchain, possibly reducing usage
of the generated one for initial users. And I guess we would stick to
the external toolchain as a default for the future because it's what
was there initially.

So I would prefer waiting until we have a working
Buildroot-generated toolchain and initially support only that. Support
for an external toolchain can be added easily later, in case the
generated one were not suitable for good reasons.

Do you have any updates on your work to generate a minimal Microblaze
toolchain within Buildroot? Should you be facing any issues, remember
the Buildroot community can be very helpful!

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot