From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/skeleton: drop $(HOST_DIR)/usr compatibility symlink
Date: Mon, 10 Apr 2023 18:51:57 +0200 [thread overview]
Message-ID: <20230410165157.GD2819@scaer> (raw)
In-Reply-To: <20230409210814.496117-1-arnout@mind.be>
Arnout, All,
On 2023-04-09 23:08 +0200, Arnout Vandecappelle spake thusly:
> It has been years that we removed $(HOST_DIR)/usr. Because of this
> symlink, however, there are still packages that install things in
> $(HOST_DIR)/usr. Remove the symlink so those packages will start to
> fail.
>
> Note that there's now a check-package check to detect such incorrectly
> instaled things, so this should only affect external packages.
>
> Signed-off-by: Arnout Vandecappelle <arnout@mind.be>
> ---
> package/skeleton/skeleton.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/package/skeleton/skeleton.mk b/package/skeleton/skeleton.mk
> index 634c76e437..186cb60189 100644
> --- a/package/skeleton/skeleton.mk
> +++ b/package/skeleton/skeleton.mk
> @@ -11,11 +11,7 @@
> SKELETON_ADD_TOOLCHAIN_DEPENDENCY = NO
> SKELETON_ADD_SKELETON_DEPENDENCY = NO
>
> -# We create a compatibility symlink in case a post-build script still
> -# uses $(HOST_DIR)/usr
> define HOST_SKELETON_INSTALL_CMDS
> -# check-package DoNotInstallToHostdirUsr
> - $(Q)ln -snf . $(HOST_DIR)/usr
Should we have a kind of post-isntall test that checks that a package
did not create that (e.g. because their makefile hard-codes something
like DESTDIR/usr)?
This is probably a good candidate for GLOBAL_INSTRUMENTATION_HOOKS, no?
Regards,
Yann E. MORIN.
> $(Q)mkdir -p $(HOST_DIR)/lib
> $(Q)mkdir -p $(HOST_DIR)/include
> $(Q)case $(HOSTARCH) in \
> --
> 2.39.2
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-04-10 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 21:08 [Buildroot] [PATCH] package/skeleton: drop $(HOST_DIR)/usr compatibility symlink Arnout Vandecappelle
2023-04-10 16:51 ` Yann E. MORIN [this message]
2023-04-10 19:05 ` Arnout Vandecappelle
2023-04-10 19:25 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230410165157.GD2819@scaer \
--to=yann.morin.1998@free.fr \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox