Re: [Buildroot] [PATCH v2 3/3] board/qemu/start-qemu.sh.in: support launching with host system's qemu

["Yann E. MORIN" <yann.morin.1998@free.fr>]

James, All,

On 2023-04-07 01:21 -0400, James Knight spake thusly:
> Provides the ability to use a host system's QEMU. While a Buildroot
> generated QEMU should work for most cases, a developer may wish to use
> the system's QEMU for options which may not have been configured in the
> Buildroot's QEMU build (e.g. configuring a different display mode).
> 
> Signed-off-by: James Knight <james.d.knight@live.com>
> ---
> Changes v1 -> v2:
>   - From the original patch, this third patch now only contains changes
>     related to permitting a system QEMU usage.
>   - Change from `--host` to `--use-system-qemu` (suggested by Romain).
> ---
>  board/qemu/start-qemu.sh.in | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/board/qemu/start-qemu.sh.in b/board/qemu/start-qemu.sh.in
> index dd387507f8867778ec73f49d769679dcd0956fd4..51f15b3ecdfdc8151caeae90582ad1142d122e69 100644
> --- a/board/qemu/start-qemu.sh.in
> +++ b/board/qemu/start-qemu.sh.in
> @@ -4,9 +4,11 @@ BINARIES_DIR="${0%/*}/"
>  cd ${BINARIES_DIR}
>  
>  mode_serial=0
> +mode_sys_qemu=0
>  while [ "$1" ]; do
>      case "$1" in
>      --serial-only|serial-only) mode_serial=1; shift;;
> +    --use-system-qemu) mode_sys_qemu=1; shift;;

I also swotched to false/true here...

>      --) shift; break;;
>      *) echo "unknown option: $1" 1>&2; exit 1;;
>      esac
> @@ -22,6 +24,9 @@ if [ "$*" ]; then
>      echo "(warning) unsupported options: $*"
>  fi
>  
> -export PATH="${HOST_DIR}/bin:${PATH}"
> +if [ $mode_sys_qemu -ne 1 ]; then

... and here.

Applied to master, thanks.

Regards,
Yann E. MORIN.

> +    export PATH="${HOST_DIR}/bin:${PATH}"
> +fi
> +
>  exec VAR_QEMU_CMD_LINE ${EXTRA_ARGS} "$@"
>  )
> -- 
> 2.39.1.windows.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot