Re: [Buildroot] [PATCH v2 1/1] package/openocd: bump to 0.12.0

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Dario, All,

On 2023-04-11 22:39 +0200, Dario Binacchi spake thusly:
[--SNIP--]
> The new version moves the GPL-2.0 license from COPYING to the subfolder
> "preferred", adding the header required by spdxcheck.py. A minimalist
> COPYING is added in the top directory, as required by automake, pointing
> to the files in LICENSES.
[--SNIP--]
> diff --git a/package/openocd/openocd.mk b/package/openocd/openocd.mk
> index 37a06ca848b7..2645f9a02465 100644
> --- a/package/openocd/openocd.mk
> +++ b/package/openocd/openocd.mk
> @@ -4,12 +4,20 @@
>  #
>  ################################################################################
>  
> -OPENOCD_VERSION = 0.11.0
> +OPENOCD_VERSION = 0.12.0
>  OPENOCD_SOURCE = openocd-$(OPENOCD_VERSION).tar.bz2
>  OPENOCD_SITE = http://sourceforge.net/projects/openocd/files/openocd/$(OPENOCD_VERSION)
> -OPENOCD_LICENSE = GPL-2.0+
> -OPENOCD_LICENSE_FILES = COPYING
> -# 0002-configure-enable-build-on-uclinux.patch patches configure.ac
> +OPENOCD_LICENSE = GPL-2.0+ (code), GFDL-1.2-no-invariants-or-later (docs), \
> +	GPL-3.0+, (stand-alone code), BSD-1-clause, BSD-2-clause, BSD-3-clause, \
> +	MIT, BSD-Source-Code, eCos-exception-2.0
> +OPENOCD_LICENSE_FILES = COPYING LICENSES/exceptions/eCos-exception-2.0 \
> +	LICENSES/license-rules.txt LICENSES/preferred/BSD-1-Clause \
> +	LICENSES/preferred/BSD-2-Clause LICENSES/preferred/BSD-2-Clause-Views \
> +	LICENSES/preferred/BSD-3-Clause LICENSES/preferred/BSD-Source-Code \
> +	LICENSES/preferred/GFDL-1.2 LICENSES/preferred/gfdl-1.2.texi.readme \
> +	LICENSES/preferred/GPL-2.0 LICENSES/preferred/MIT \
> +	LICENSES/stand-alone/GPL-3.0
> +# 0001-configure-enable-build-on-uclinux.patch patches configure.ac

This is a bit difficult to read, so I changed it to one-item per line.

Also, listing the eCos exception by itself was a little weird, so I
looked at the code, and it turns out there a single file that references
that exception:
    src/flash/nand/ecc.c

The SPDX identifier for that file is:
    SPDX-License-Identifier: GPL-2.0-or-later WITH eCos-exception-2.0

It is part of openocd itself (the executalbe), via libopenocd.la (which
is a convenience library, i.e. a static lib that is not installed).

So, I believe the real licening terms should be:

    OPENOCD_LICENSE = \
        BSD-1-clause, \
        BSD-2-clause, \
        BSD-2-Clause-Views, \
        BSD-3-clause, \
        BSD-Source-Code, \
        GFDL-1.2-no-invariants-or-later (docs), \
        GPL-2.0+ eith eCos-exception-2.0 (code), \
        GPL-3.0+ (stand-alone code), \
        MIT

I was about to do so before I pushed, but I'd like a bit of feedback...

Thoughts?

Anyway, as all the licensing details were there, I pushed without the
above issue addressed, so can you please look into sending a follow-up
patch to explain fix it and all the above, please?

Regards,
Yann E. MORIN.

>  OPENOCD_AUTORECONF = YES
>  OPENOCD_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -std=gnu99"
>  
> -- 
> 2.32.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot