Re: [Buildroot] [PATCH v2 1/1] package/python-evdev: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Witold, All,

On 2023-04-17 15:03 +0200, Witold Lipieta spake thusly:
> evdev 1.6.1 https://pypi.org/project/evdev/
> 
> Signed-off-by: Witold Lipieta <witold.lipieta@thaumatec.com>
> ---
> Changes v1 -> v2:
>  - remove runtime dependency
>  - add dependency on linux 4.4 headers
>  - pass path to uinput.h during setup
>  - add basic runtime check

Thanks for the runtime test!

[--SNIP--]
> diff --git a/package/python-evdev/Config.in b/package/python-evdev/Config.in
> new file mode 100644
> index 0000000000..91e4642d48
> --- /dev/null
> +++ b/package/python-evdev/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_PYTHON_EVDEV
> +	bool "python-evdev"
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4
> +	help
> +	  Bindings to the Linux input handling subsystem.
> +
> +	  https://github.com/gvalkov/python-evdev

When there is a dependency on toolchain features, we add a comment about
that:

    comment "python-evdev needs a toolchain w/ headers >= 4.4"
        depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4

So i've added that.

[--SNIP--]
> diff --git a/support/testing/tests/package/test_python_evdev.py b/support/testing/tests/package/test_python_evdev.py
> new file mode 100644
> index 0000000000..f2d64c7bd1
> --- /dev/null
> +++ b/support/testing/tests/package/test_python_evdev.py
> @@ -0,0 +1,12 @@
> +from tests.package.test_python import TestPythonPackageBase
> +
> +
> +class TestPythonPy3Evdev(TestPythonPackageBase):
> +    __test__ = True
> +    config = TestPythonPackageBase.config + \
> +        """
> +        BR2_PACKAGE_PYTHON3=y
> +        BR2_PACKAGE_PYTHON_EVDEV=y
> +        """
> +    sample_scripts = ["tests/package/sample_python_evdev.py"]
> +    
> \ No newline at end of file

    $ make check-package
    support/testing/tests/package/test_python_evdev.py:0: run 'flake8' and fix the warnings
    support/testing/tests/package/test_python_evdev.py:12:1: W391 blank line at end of file
    support/testing/tests/package/test_python_evdev.py:12:1: W293 blank line contains whitespace
    1     W293 blank line contains whitespace
    1     W391 blank line at end of file

I also fixed that (and the "No newline at end of file" issue).

Applied to master, thanks.

Regards,
Yann E. MORIN.

> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot