Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Perez de Castro <aperez@igalia.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Thomas Devoogdt <thomas.devoogdt@barco.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v5 4/5] package/libgtk3: re-enable atk-bridge
Date: Mon, 24 Apr 2023 15:14:21 +0300	[thread overview]
Message-ID: <20230424151421.GH3960430@igalia.com> (raw)
In-Reply-To: <20230227105838.358916-4-thomas.devoogdt@barco.com>


[-- Attachment #1.1: Type: text/plain, Size: 2621 bytes --]

On Mon, 27 Feb 2023 11:58:37 +0100 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> The at-spi2-core and at-spi2-atk were merged, and are now built by default,
> so this patch is no longer required.
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>

Tested-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v5: added re-enable atk-bridge patch to the package/at-spi2-core: bump to version 2.47.1 group
> ---
>  package/libgtk3/0001-disable-atk-bridge.patch | 41 -------------------
>  1 file changed, 41 deletions(-)
>  delete mode 100644 package/libgtk3/0001-disable-atk-bridge.patch
> 
> diff --git a/package/libgtk3/0001-disable-atk-bridge.patch b/package/libgtk3/0001-disable-atk-bridge.patch
> deleted file mode 100644
> index f3e9bff2ba..0000000000
> --- a/package/libgtk3/0001-disable-atk-bridge.patch
> +++ /dev/null
> @@ -1,41 +0,0 @@
> -Remove atk-bridge support.
> -
> -atk-bridge doesn't seem useful for now in Buildroot and requires to
> -add two new packages just for it: at-spi2-core and at-spi2-atk.
> -
> -Signed-off-by: Hadrien Boutteville <hadrien.boutteville@gmail.com>
> -
> ---- a/gtk/a11y/gtkaccessibility.c
> -+++ b/gtk/a11y/gtkaccessibility.c
> -@@ -37,10 +37,6 @@
> - #include <gtk/gtktogglebutton.h>
> - #include <gtk/gtkaccessible.h>
> -
> --#ifdef GDK_WINDOWING_X11
> --#include <atk-bridge.h>
> --#endif
> --
> - static gboolean gail_focus_watcher      (GSignalInvocationHint *ihint,
> -                                          guint                  n_param_values,
> -                                          const GValue          *param_values,
> -@@ -988,9 +984,5 @@ _gtk_accessibility_init (void)
> -   _gtk_accessibility_override_atk_util ();
> -   do_window_event_initialization ();
> -
> --#ifdef GDK_WINDOWING_X11
> --  atk_bridge_adaptor_init (NULL, NULL);
> --#endif
> --
> -   atk_misc_instance = g_object_new (GTK_TYPE_MISC_IMPL, NULL);
> - }
> ---- a/meson.build
> -+++ b/meson.build
> -@@ -564,7 +564,7 @@ if x11_enabled
> -   xfixes_dep     = dependency('xfixes', required: false)
> -   xcomposite_dep = dependency('xcomposite', required: false)
> -   fontconfig_dep = dependency('fontconfig', fallback: ['fontconfig', 'fontconfig_dep'])
> --  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req)
> -+  atkbridge_dep  = dependency('atk-bridge-2.0', version: at_spi2_atk_req, required: false)
> - 
> -   backend_immodules += ['xim']
> - 
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-04-24 12:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 10:58 [Buildroot] [PATCH v5 1/5] package/at-spi2-core: bump to version 2.47.1 Thomas Devoogdt
2023-02-27 10:58 ` [Buildroot] [PATCH v5 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
2023-04-24 12:13   ` Adrian Perez de Castro
2023-02-27 10:58 ` [Buildroot] [PATCH v5 3/5] package/atk: " Thomas Devoogdt
2023-04-15 15:37   ` Yann E. MORIN
2023-04-21  9:55     ` Adrian Perez de Castro
2023-04-24 12:13   ` Adrian Perez de Castro
2023-02-27 10:58 ` [Buildroot] [PATCH v5 4/5] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
2023-04-24 12:14   ` Adrian Perez de Castro [this message]
2023-02-27 10:58 ` [Buildroot] [PATCH v5 5/5] package/libgtk3: fix update-icon-cache on empty directory Thomas Devoogdt
2023-04-24 12:14   ` Adrian Perez de Castro
2023-06-08 20:52     ` Peter Korsgaard
2023-04-24 12:11 ` [Buildroot] [PATCH v5 1/5] package/at-spi2-core: bump to version 2.47.1 Adrian Perez de Castro
2023-04-25 14:30   ` Adrian Perez de Castro
2023-04-27 14:41     ` Adrian Perez de Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230424151421.GH3960430@igalia.com \
    --to=aperez@igalia.com \
    --cc=buildroot@buildroot.org \
    --cc=thomas.devoogdt@barco.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox