Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Nosthoff via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: Adrian Perez de Castro <aperez@igalia.com>
Subject: [Buildroot] [PATCH] package/wpewebkit: fix NEON build with gcc-12
Date: Mon,  1 May 2023 14:32:03 +0200	[thread overview]
Message-ID: <20230501123211.18167-1-buildroot@heine.tech> (raw)

since gcc-12 gcc complains about attributes in between decl-specifiers.
This code is NEON specific so it should not appear on builds for other systems.

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

---

@Adrian: should I submit this somewhere upstream? Or would it make more sense to
include this in the other NEON specific patch?
---
 .../0002-change-position-of-alignas.patch     | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/wpewebkit/0002-change-position-of-alignas.patch

diff --git a/package/wpewebkit/0002-change-position-of-alignas.patch b/package/wpewebkit/0002-change-position-of-alignas.patch
new file mode 100644
index 0000000000..5a1564c4c1
--- /dev/null
+++ b/package/wpewebkit/0002-change-position-of-alignas.patch
@@ -0,0 +1,33 @@
+From e2a3e36c8df59d83de0a48b806cad5bb5515a658 Mon Sep 17 00:00:00 2001
+From: Michael Nosthoff <michael.nosthoff@iba-group.com>
+Date: Tue, 18 Apr 2023 19:47:03 +0200
+Subject: [PATCH] change position of alignas
+
+fixes:
+Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp:38:8: error: standard attributes in middle of decl-specifiers
+   38 | static alignas(16) short s_FELightingConstantsForNeon[] = {
+      |        ^~~~~~~
+
+on gcc-12
+
+Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
+---
+ .../platform/graphics/cpu/arm/filters/FELightingNEON.cpp        | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp
+index 64950d1732e8..cafb4ee184ba 100644
+--- a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp
++++ b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.cpp
+@@ -35,7 +35,7 @@ namespace WebCore {
+ //   ALPHAX_Q ALPHAY_Q REMAPX_D REMAPY_D
+ 
+ 
+-static alignas(16) short s_FELightingConstantsForNeon[] = {
++static short alignas(16) s_FELightingConstantsForNeon[] = {
+     // Alpha coefficients.
+     -2, 1, 0, -1, 2, 1, 0, -1,
+     0, -1, -2, -1, 0, 1, 2, 1,
+-- 
+2.34.1
+
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2023-05-01 12:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01 12:32 Michael Nosthoff via buildroot [this message]
2023-07-29 22:08 ` [Buildroot] [PATCH] package/wpewebkit: fix NEON build with gcc-12 Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230501123211.18167-1-buildroot@heine.tech \
    --to=buildroot@buildroot.org \
    --cc=aperez@igalia.com \
    --cc=buildroot@heine.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox