Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Johnson via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: David Johnson <dave-git@centerclick.org>
Subject: [Buildroot] [PATCH 2/2] package/netsnmp: add a snmp user so snmpd doesn't run as root
Date: Mon,  1 May 2023 16:36:47 -0400	[thread overview]
Message-ID: <20230501203647.1177608-2-dave-git@centerclick.org> (raw)
In-Reply-To: <20230501203647.1177608-1-dave-git@centerclick.org>

Signed-off-by: David Johnson <dave-git@centerclick.org>
---
 package/netsnmp/S59snmpd      | 2 +-
 package/netsnmp/netsnmp.mk    | 4 ++++
 package/netsnmp/snmpd.service | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/package/netsnmp/S59snmpd b/package/netsnmp/S59snmpd
index 96ed8237ac..aece896670 100644
--- a/package/netsnmp/S59snmpd
+++ b/package/netsnmp/S59snmpd
@@ -17,7 +17,7 @@ export PATH=/sbin:/usr/sbin:/bin:/usr/bin
 # Defaults
 export MIBDIRS=/usr/share/snmp/mibs
 SNMPDRUN=yes
-SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1'
+SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid -u snmp -g snmp 127.0.0.1'
 TRAPDRUN=no
 TRAPDOPTS='-Lsd -p /var/run/snmptrapd.pid'
 
diff --git a/package/netsnmp/netsnmp.mk b/package/netsnmp/netsnmp.mk
index 0218e65b91..c7df49f947 100644
--- a/package/netsnmp/netsnmp.mk
+++ b/package/netsnmp/netsnmp.mk
@@ -41,6 +41,10 @@ NETSNMP_INSTALL_TARGET_OPTS = DESTDIR=$(TARGET_DIR) LIB_LDCONFIG_CMD=true instal
 NETSNMP_MAKE = $(MAKE1)
 NETSNMP_CONFIG_SCRIPTS = net-snmp-config
 
+define NETSNMP_USERS
+	snmp -1 snmp -1 * - - - snmpd user
+endef
+
 ifeq ($(BR2_INIT_SYSTEMD),y)
 NETSNMP_CONF_OPTS += --with-systemd
 else
diff --git a/package/netsnmp/snmpd.service b/package/netsnmp/snmpd.service
index 2a1e6e9715..6647b10c32 100644
--- a/package/netsnmp/snmpd.service
+++ b/package/netsnmp/snmpd.service
@@ -6,7 +6,7 @@ ConditionPathExists=/etc/snmp/snmpd.conf
 [Service]
 Type=simple
 Environment=MIBDIRS=/usr/share/snmp/mibs
-Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid 127.0.0.1'
+Environment=SNMPDOPTS='-Lsd -Lf /dev/null -p /var/run/snmpd.pid -u snmp -g snmp 127.0.0.1'
 EnvironmentFile=-/etc/default/snmpd
 PassEnvironment=MIBDIRS
 ExecStart=/usr/sbin/snmpd -f $SNMPDOPTS
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-05-01 20:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01 20:36 [Buildroot] [PATCH 1/2] package/netsnmp: add systemd service file David Johnson via buildroot
2023-05-01 20:36 ` David Johnson via buildroot [this message]
2023-08-09 18:47 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230501203647.1177608-2-dave-git@centerclick.org \
    --to=buildroot@buildroot.org \
    --cc=dave-git@centerclick.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox