Re: [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory

From: Adrian Perez de Castro <aperez@igalia.com>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
	Thomas Devoogdt <thomas@devoogdt.com>,
	Daniel Lang <d.lang@abatec.at>,
	Thomas Devoogdt <thomas.devoogdt@barco.com>,
	James Knight <james.knight@collins.com>,
	buildroot@buildroot.org,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory
Date: Fri, 5 May 2023 14:57:22 +0300	[thread overview]
Message-ID: <20230505145722.GJ3311548@igalia.com> (raw)
In-Reply-To: <20230428075920.3750005-5-thomas@devoogdt.com>


[-- Attachment #1.1: Type: text/plain, Size: 1562 bytes --]

On Fri, 28 Apr 2023 09:59:20 +0200 Thomas Devoogdt <thomas@devoogdt.com> wrote:
> If both, hicolor-icon-theme (selected by libgtk3-demo) and
> adwaita-icon-theme is not selected, then the /usr/share/icons
> folder is empty, causing find to fail.
> 
> Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
> Tested-by: Adrian Perez de Castro <aperez@igalia.com>

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

> ---
> v5: 
>  - Fixed indentation.
>  - Grouped patches.
> v6: no change
> v7: no change
> ---
>  package/libgtk3/libgtk3.mk | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
> index bdd54dcdc8..eac569fd41 100644
> --- a/package/libgtk3/libgtk3.mk
> +++ b/package/libgtk3/libgtk3.mk
> @@ -146,8 +146,9 @@ endef
>  # Create icon-theme.cache for each of the icon directories/themes
>  # It's not strictly necessary but speeds up lookups
>  define LIBGTK3_UPDATE_ICON_CACHE
> -	find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
> -		-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
> +	[ ! -d $(TARGET_DIR)/usr/share/icons ] || \
> +		find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
> +			-exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
>  endef
>  LIBGTK3_TARGET_FINALIZE_HOOKS += LIBGTK3_UPDATE_ICON_CACHE
>  
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

Cheers,
—Adrián

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot