Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/openblas: bump to version v0.3.23
Date: Sun, 7 May 2023 20:54:50 +0200	[thread overview]
Message-ID: <20230507185450.GC252090@scaer> (raw)
In-Reply-To: <20230507181424.246228-1-ju.o@free.fr>

Julien, All,

On 2023-05-07 20:14 +0200, Julien Olivain spake thusly:
> This commit also:
> - adds the md5 from the release note in the package hash file,
> - rebase the patch on the new version tag,
> - adds the "Upstream:" tag in the patch.
> 
> For change log since v0.3.22, see:
> - https://github.com/xianyi/OpenBLAS/releases/tag/v0.3.23
> 
> Signed-off-by: Julien Olivain <ju.o@free.fr>
> ---
>  ...ile.system-don-t-specify-optimization-level-bui.patch | 9 +++++----
>  package/openblas/openblas.hash                           | 4 +++-
>  package/openblas/openblas.mk                             | 2 +-
>  3 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/package/openblas/0001-Makefile.system-don-t-specify-optimization-level-bui.patch b/package/openblas/0001-Makefile.system-don-t-specify-optimization-level-bui.patch
> index e0c738748a..ed3cae82ef 100644
> --- a/package/openblas/0001-Makefile.system-don-t-specify-optimization-level-bui.patch
> +++ b/package/openblas/0001-Makefile.system-don-t-specify-optimization-level-bui.patch
> @@ -1,4 +1,4 @@
> -From d8ec4e4c6ef69165179f376e365034de10e6fee3 Mon Sep 17 00:00:00 2001
> +From 89648b76e35dc4657942c861ed9dbfbfe5a3df28 Mon Sep 17 00:00:00 2001
>  From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>  Date: Fri, 5 Mar 2021 14:09:23 +0100
>  Subject: [PATCH] Makefile.system: don't specify optimization level
> @@ -11,16 +11,17 @@ The CFLAGS/FFLAGS would e.g. contain '-Os -O2' in which -O2 survives.
>  
>  Remove the optimization level specified in openblas itself.
>  
> +Upstream: N/A, not upstreamable

My post-applypatch hook triggered, and Baruch noticed:

    $ ./utils/docker-run make check-package
    package/openblas/0001-Makefile.system-don-t-specify-optimization-level-bui.patch:0: Upstream was expected to fail, did you fix the file and forget to update .checkpackageignore?

Applied to master, with the above fixed, thanks.

Regards,
Yann E. MORIN.

>  Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
>  ---
>   Makefile.system | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>  
>  diff --git a/Makefile.system b/Makefile.system
> -index 438a8148..9de1bbd5 100644
> +index 343b94bb3..c355ca5d9 100644
>  --- a/Makefile.system
>  +++ b/Makefile.system
> -@@ -1519,11 +1519,11 @@ FCOMMON_OPT += -g
> +@@ -1585,11 +1585,11 @@ FCOMMON_OPT += -g
>   endif
>   
>   ifndef COMMON_OPT
> @@ -35,5 +36,5 @@ index 438a8148..9de1bbd5 100644
>   
>   override CFLAGS     += $(COMMON_OPT) $(CCOMMON_OPT) -I$(TOPDIR)
>  -- 
> -2.35.1
> +2.40.1
>  
> diff --git a/package/openblas/openblas.hash b/package/openblas/openblas.hash
> index a8b5527e81..2e5fa8865f 100644
> --- a/package/openblas/openblas.hash
> +++ b/package/openblas/openblas.hash
> @@ -1,3 +1,5 @@
> +# From https://github.com/xianyi/OpenBLAS/releases/tag/v0.3.23
> +md5  115634b39007de71eb7e75cf7591dfb2  openblas-0.3.23.tar.gz
>  # Locally calculated
> -sha256  7fa9685926ba4f27cfe513adbf9af64d6b6b63f9dcabb37baefad6a65ff347a7  openblas-0.3.22.tar.gz
> +sha256  5d9491d07168a5d00116cdc068a40022c3455bf9293c7cb86a65b1054d7e5114  openblas-0.3.23.tar.gz
>  sha256  190b5a9c8d9723fe958ad33916bd7346d96fab3c5ea90832bb02d854f620fcff  LICENSE
> diff --git a/package/openblas/openblas.mk b/package/openblas/openblas.mk
> index 27f20654e7..f7a50d7bc7 100644
> --- a/package/openblas/openblas.mk
> +++ b/package/openblas/openblas.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -OPENBLAS_VERSION = 0.3.22
> +OPENBLAS_VERSION = 0.3.23
>  OPENBLAS_SITE = https://github.com/xianyi/OpenBLAS/releases/download/v$(OPENBLAS_VERSION)
>  OPENBLAS_LICENSE = BSD-3-Clause
>  OPENBLAS_LICENSE_FILES = LICENSE
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2023-05-07 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 18:14 [Buildroot] [PATCH 1/1] package/openblas: bump to version v0.3.23 Julien Olivain
2023-05-07 18:28 ` Baruch Siach via buildroot
2023-05-07 18:56   ` Yann E. MORIN
2023-05-07 18:54 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230507185450.GC252090@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox