From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85504C77B7C for ; Sun, 7 May 2023 20:24:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2974B613F7; Sun, 7 May 2023 20:24:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2974B613F7 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hAt1ty8NR4wS; Sun, 7 May 2023 20:24:04 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 4F05A60BDC; Sun, 7 May 2023 20:24:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4F05A60BDC Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id BFD9D1BF2CC for ; Sun, 7 May 2023 20:24:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 98BD740395 for ; Sun, 7 May 2023 20:24:01 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 98BD740395 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S4JnGkRF8jcs for ; Sun, 7 May 2023 20:24:00 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 432CF401A3 Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by smtp2.osuosl.org (Postfix) with ESMTPS id 432CF401A3 for ; Sun, 7 May 2023 20:24:00 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b44:b00:7bde:4dbc:bac0:54b7]) (Authenticated sender: yann.morin.1998@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 5CF682003DD; Sun, 7 May 2023 22:23:54 +0200 (CEST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Sun, 07 May 2023 22:23:54 +0200 Date: Sun, 7 May 2023 22:23:53 +0200 From: "Yann E. MORIN" To: Leon Rinkel Message-ID: <20230507202353.GL252090@scaer> References: <20230507195031.163142-1-leon@rinkel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230507195031.163142-1-leon@rinkel.me> User-Agent: Mutt/1.5.22 (2013-10-16) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1683491037; bh=wqEzv7LKPVhqtZVRqJychL6xlR2I0CX/sCnCfDlikg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=skGWBCC49/izvOh2+iL6S51TYf8nDGuCpwtdbGH3D3rEMqb9Y+KDTmxIDN2cOhN7a vRDcNydsiP1uUzbqRyjx75FTPsjQ++oFWhuwxo06EuLFE3U9xaITq6ymwYqlBFl2VX dn82j4JR74fT4tPPklKFZFVtDZmSPUlsqsqBkdl5zlNQq00sY8qmOpfucc1oScP02T UzWRJTPxH5cA/U199VtGsVdlrxNcn6XVHXG/iq30cxkTibP2WMC0cXqyPYlVQoOI68 TpwuJWLfNp/UhzERTMFXWblivWw8WO4x9/AabtJTr8JqDV9F35coQBQAdJ0+dm08zG sHNlqQ3zo++aA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=skGWBCC4 Subject: Re: [Buildroot] [PATCH 1/1] package/bat: bump version to 0.23.0 X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Pierret , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Leon, All, Thanks for this patch. However, I have a important comment about it, see below... On 2023-05-07 19:50 +0000, Leon Rinkel spake thusly: > Signed-off-by: Leon Rinkel > --- > package/bat/bat.hash | 4 ++-- > package/bat/bat.mk | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/package/bat/bat.hash b/package/bat/bat.hash > index f4d3e32c34..a79cb8f9a3 100644 > --- a/package/bat/bat.hash > +++ b/package/bat/bat.hash > @@ -1,4 +1,4 @@ > # Locally generated > -sha256 7940641baaa61cd3bcd1c3db4804d179609d6ccd955868928a129bf3f853e0b2 bat-0.19.0.tar.gz > +sha256 b29af37f274019cf1a36d9483c6f30ff780d3be9d0a9e6a96a43737388b7e409 bat-0.23.0.tar.gz > sha256 c71d239df91726fc519c6eb72d318ec65820627232b2f796219e87dcf35d0ab4 LICENSE-APACHE > -sha256 64de710b6309a7db5e44ad0af382300c7fb6f6d116d8ae32f0164e05db033068 LICENSE-MIT > +sha256 dccda9eb9533f5c65624a1106536c6cfde46008d58e60b3faf154e8b9fd5b46e LICENSE-MIT When you update the hash for a license file, it merans the file has changed. We have hashes for liocense files, explicitly to detect that they have changed, so that we can assess whether the licensing terms have changed (or not). Silently updating the license hash without explaining what has changed, defeats the purpose for what we have those hashes to begin with. In this case, the change is due to an update in the copyright years, so just state that in the commit log, something along the lines of: Update hash for LICENSE-MIT, to account for an update in the copyright years: https://github.com/sharkdp/bat/commit/d43d241f5bac0fde7881b55f61644e0408181cf7 Care to respoin, please? Regards, Yann E. MORIN. > diff --git a/package/bat/bat.mk b/package/bat/bat.mk > index dc29a85429..395134df17 100644 > --- a/package/bat/bat.mk > +++ b/package/bat/bat.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -BAT_VERSION = 0.19.0 > +BAT_VERSION = 0.23.0 > BAT_SITE = $(call github,sharkdp,bat,v$(BAT_VERSION)) > BAT_LICENSE = Apache-2.0 or MIT > BAT_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot