Re: [Buildroot] [PATCH 1/2] package/pkg-utils.mk: suppress kconfig set/disable operations

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Knight <james.d.knight@live.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/pkg-utils.mk: suppress kconfig set/disable operations
Date: Sun, 7 May 2023 23:05:29 +0200	[thread overview]
Message-ID: <20230507210529.GM252090@scaer> (raw)
In-Reply-To: <SN4P221MB0682F08F5BA15071DDED63A7A0729@SN4P221MB0682.NAMP221.PROD.OUTLOOK.COM>

James, All,

I was very confused about the title. But it is not about "suppressing"
thsoe operations, but really about making them quiet. So I tweaked the
commit title a bit...

(Unless I don't know all the meanings of suppress, which is totally
possible, but then I still got confused, and the new title is still
more explicit.)

On 2023-05-04 23:43 -0400, James Knight spake thusly:
> In a previous commit [1], the use of `KCONFIG_ENABLE_OPT` was tweaked in
> a way which no longer generates a default output unless the quiet flag
> is unset (`Q=`). The use of `KCONFIG_SET_OPT` and `KCONFIG_DISABLE_OPT`
> does not apply a quiet operation. In order to make all these kernel
> configuration defines operate in a consistent way, adjusting both
> `KCONFIG_SET_OPT` and `KCONFIG_DISABLE_OPT` to be default-quiet as well.
> 
> [1]: 66d2ff25bad813659ed4541b3f4c6c2a09455bd7
> 
> Signed-off-by: James Knight <james.d.knight@live.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/pkg-utils.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> index 0945e6ed318ab4d176ce6d4efa3906e537f2b982..530638566c05094080b8defb098c131aa4981767 100644
> --- a/package/pkg-utils.mk
> +++ b/package/pkg-utils.mk
> @@ -34,9 +34,9 @@ define KCONFIG_ENABLE_OPT
>  	fi
>  endef
>  # KCONFIG_SET_OPT (option, value [, file])
> -KCONFIG_SET_OPT     = $(call KCONFIG_MUNGE_DOT_CONFIG, $(1), $(1)=$(2), $(3))
> +KCONFIG_SET_OPT     = $(Q)$(call KCONFIG_MUNGE_DOT_CONFIG, $(1), $(1)=$(2), $(3))
>  # KCONFIG_DISABLE_OPT  (option [, file])
> -KCONFIG_DISABLE_OPT = $(call KCONFIG_MUNGE_DOT_CONFIG, $(1), $(SHARP_SIGN) $(1) is not set, $(2))
> +KCONFIG_DISABLE_OPT = $(Q)$(call KCONFIG_MUNGE_DOT_CONFIG, $(1), $(SHARP_SIGN) $(1) is not set, $(2))
>  
>  # Helper functions to determine the name of a package and its
>  # directory from its makefile directory, using the $(MAKEFILE_LIST)
> -- 
> 2.40.1.windows.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot